Skip to content

feat(pii): data collection for PHP - #19803

Merged
Litarnus merged 6 commits into
masterfrom
php-data-colleciton
Oct 8, 2026
Merged

Litarnus merged 6 commits into
masterfrom
php-data-colleciton

Conversation

@Litarnus

@Litarnus Litarnus commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

DESCRIBE YOUR PR

Adds documentation for data collection for PHP. It keeps the current send_default_pii page intact and instead references a new version with data collection. Once we make it the default, we will change it so that the data collection page becomes the main page

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace YYYY-MM-DD with the due date. You can update this information later by editing the PR description.

  • Urgent deadline (GA date, etc.): YYYY-MM-DD
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've supplied a deadline.

Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel

vercel Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-docs Ready Ready Preview Oct 8, 2026 2:08pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
develop-docs Ignored Ignored Preview Oct 8, 2026 2:08pm UTC

Request Review

@github-actions github-actions Bot added the Priority: Needs Triage The PR description is missing valid priority information label Oct 5, 2026
@codeowner-assignment
codeowner-assignment Bot requested a review from a team October 5, 2026 11:42
@cursor

cursor Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

This change adds a PHP Data Collection docs page and points the existing PII pages at it. The old send_default_pii page stays live. The plan watches new-page views, sibling PHP docs views, PHP page errors, and docs 404s. An issue escalates when the new page stays unused while sibling PHP pages still load, or when PHP errors or 404s rise.

Monitoring in production

Services: sentry-docs.

Mention @change-monitor in a comment to update the plan.

Plan

What changed

Requests to /platforms/php/data-management/data-collection/ now return a Data Collection page. The PHP options, Data Collected, and Sensitive Data pages now link to that page. The send_default_pii docs stay. Laravel and Symfony do not get the new page. This ships when sentry-docs deploys.

Risk

A bad MDX build can 404 the new page or break shared PHP options pages. The common options file also feeds Laravel. A failed PlatformSection can show the new option on Laravel or Symfony. Users then get a missing page or wrong PII guidance.

Intended effect

The new page is live when sampled pageload or navigation spans for its URL rise above zero. Absent means that count stays at zero while sibling PHP pages still get traffic. Traces sample at 30 percent. Transaction name is /:path*?. Filter on http.url.

Signal Baseline Rule Source
New Data Collection page views 0 sampled pageload or navigation spans in 2026-10-04T11:42:00Z to 2026-10-05T11:42:00Z Confirmed when the 24h count rises above 0. Absent when it stays 0 while PHP Data Collected or PHP options still have views Sentry org sentry project docs. Query: environment:production (span.op:pageload OR span.op:navigation) http.url:*docs.sentry.io/platforms/php/data-management/data-collection*
PHP Data Collected page views 3 sampled pageloads, p95 2068ms, same window. Navigation count 0 Hold above 0 over 24h. This page must stay reachable Same dataset. Query: environment:production (span.op:pageload OR span.op:navigation) http.url:*docs.sentry.io/platforms/php/data-management/data-collected*

Regression watch

This diff can break PHP data-management pages and shared PHP options pages. Watch errors and 404s, not only new-page views. The one PHP error in the baseline window was a search fetch on /platforms/php/usage/set-level/. Treat a rise above that band as this change until proven otherwise.

Signal Baseline Rule Source
PHP page errors 1 production error in 2026-10-04T11:42:00Z to 2026-10-05T11:42:00Z. Site-wide docs errors 95 in the same window Hold PHP URL errors at 0-2 per 24h. Escalate if they rise above 2, or if site-wide errors rise above 190 Sentry org sentry project docs. PHP query: environment:production url:*platforms/php*. Site-wide: environment:production with count()
PHP docs page views 197 sampled pageloads and 157 sampled navigations in the same window Hold. Escalate if this 24h total falls toward 0 while docs.page.load for page_type:platforms stays near 12385 Spans query: environment:production (span.op:pageload OR span.op:navigation) http.url:*docs.sentry.io/platforms/php/*. Metric: metric.name:docs.page.load page_type:platforms
PHP options page views 7 sampled pageloads and 10 sampled navigations in the same window. Laravel options 10 sampled views. Symfony options 0 Hold PHP options above 0 over 24h. Escalate if PHP or Laravel options drop to 0 while other PHP pages still load PHP: http.url:*docs.sentry.io/platforms/php/configuration/options*. Laravel: http.url:*docs.sentry.io/platforms/php/guides/laravel/configuration/options*
Docs 404s docs.page.not_found sum 109 in the same window. No rows for requested_path:platforms/php Hold platforms/php at 0. Escalate if that path appears, or if the site-wide 24h sum rises above 220 Sentry metrics, project docs. Queries: metric.name:docs.page.not_found and metric.name:docs.page.not_found requested_path:platforms/php

Not observable

Whether Laravel and Symfony hide the new option is not in telemetry. docs.page.not_found stores only the first two path segments, so a Laravel data-collection 404 looks like any other platforms/php miss. Search index coverage for the new page is not in Sentry. Reader understanding of the new defaults is not measurable here.

Comment thread docs/platforms/php/common/data-management/data-collected.mdx
@github-actions github-actions Bot added Priority: Normal Docs review has no urgent deadline and removed Priority: Needs Triage The PR description is missing valid priority information labels Oct 8, 2026
@Litarnus
Litarnus merged commit a8a7fa3 into master Oct 8, 2026
24 checks passed
@Litarnus
Litarnus deleted the php-data-colleciton branch October 8, 2026 14:18

This branch was successfully deployed

2 active (1 outdated) deployments
Preview – sentry-docs — eb2d14c3 Deployed Oct 8, 2026 by vercel[bot]
Preview – develop-docs — 67ce1cd2 Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Normal Docs review has no urgent deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants