fix(android-fragment): support detach/attach navigation in fragment tracing by romtsn · Pull Request #5660 · getsentry/sentry-java

romtsn · 2026-06-29T20:11:42Z

Summary

Fixes a silent data quality issue where detach/attach tab navigation (and similar patterns) left ui.load spans open until the 30-second activity transaction deadline, producing badly inflated performance data.

Root cause

SentryFragmentLifecycleCallbacks started spans in onFragmentCreated and stopped them in onFragmentStarted (a concession to ViewPager2 which locks background fragments to STARTED). For detach/attach navigation — manual tab switching (transaction.detach(current).attach(next).commit()), ViewPager v1 with FragmentPagerAdapter, and custom navigation frameworks that preserve fragment state — onFragmentCreated is never called for off-screen fragments. Spans would hang silently until the deadline.

Fix

Three targeted changes, all leveraging the fact that startTracing / stopTracing are already idempotent:

Hook	Change	Why
`onFragmentViewCreated`	+`startTracing`	Enables narrower `viewCreated → resumed` span for detach/attach paths. No-op if `onFragmentCreated` already started a span.
`onFragmentResumed`	+`stopTracing`	Ends the span on the detach/attach path where `onFragmentStarted` may not fire. No-op for the normal path where `onFragmentStarted` already closed the span.
`onFragmentViewDestroyed`	+`stopTracing`	Failsafe: closes any span for a fragment whose view is destroyed before reaching STARTED or RESUMED.

The normal lifecycle path (onFragmentCreated → onFragmentViewCreated → onFragmentStarted → onFragmentResumed) is completely unaffected — still produces exactly one ui.load span, closed at onFragmentStarted.

What's new for customers

Apps using detach/attach navigation will now see correct, narrower ui.load spans (viewCreated → resumed) instead of timeout-inflated spans.

Tests

Five new unit tests covering:

Detach/attach path: onFragmentViewCreated starts a span when tracing enabled
Normal path: onFragmentViewCreated is a no-op when span already running
Detach/attach path: onFragmentResumed stops the span
Normal path: onFragmentResumed does not double-finish after onFragmentStarted
Failsafe: onFragmentViewDestroyed stops a span that never reached STARTED/RESUMED

Example trace: https://sentry-sdks.sentry.io/explore/traces/trace/edb7de2bba454d70a4c13eee5bce660c/

As you can see TabFragmentB now correctly shows up after re-attaching (but wouldn't have without this fix):

Not verified

./gradlew spotlessApply apiDump could not run (no JDK in sandbox) — CI will apply formatting and regenerate .api files if needed.

…racing For detach/attach tab navigation (manual tab switching, ViewPager v1 with FragmentPagerAdapter, custom navigation frameworks), onFragmentCreated is skipped for off-screen fragments that are re-attached. Previously this left ui.load spans open until the 30s activity transaction deadline, producing inflated performance data. Fix by calling startTracing in onFragmentViewCreated as well as onFragmentCreated. startTracing is idempotent (no-op if a span is already running), so the normal onFragmentCreated -> onFragmentViewCreated path is unaffected. Add matching stopTracing calls in onFragmentResumed (covers the detach/attach path where onFragmentStarted may be skipped) and onFragmentViewDestroyed (failsafe for fragments destroyed before reaching STARTED or RESUMED). stopTracing is also idempotent, so the normal path is unaffected. Co-Authored-By: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>

sentry · 2026-06-29T20:13:25Z

📲 Install Builds

Android

🔗 App Name	App ID	Version	Configuration
SDK Size	io.sentry.tests.size	8.46.0 (1)	release

⚙️ sentry-android Build Distribution Settings

github-actions · 2026-06-29T20:19:23Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	313.75 ms	373.71 ms	59.96 ms
Size	0 B	0 B	0 B

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`abfcc92`	304.04 ms	370.33 ms	66.29 ms
`4e3e79d`	365.83 ms	477.62 ms	111.79 ms
`d8912da`	329.94 ms	389.68 ms	59.74 ms
`d15471f`	294.13 ms	399.49 ms	105.36 ms
`abf451a`	332.82 ms	403.67 ms	70.85 ms
`604a261`	380.65 ms	451.27 ms	70.62 ms
`806307f`	357.85 ms	424.64 ms	66.79 ms
`22f4345`	307.87 ms	354.51 ms	46.64 ms
`d217708`	375.27 ms	415.68 ms	40.41 ms
`c3ee041`	310.64 ms	361.90 ms	51.26 ms

App size

Revision	Plain	With Sentry	Diff
`abfcc92`	1.58 MiB	2.13 MiB	557.31 KiB
`4e3e79d`	0 B	0 B	0 B
`d8912da`	0 B	0 B	0 B
`d15471f`	1.58 MiB	2.13 MiB	559.54 KiB
`abf451a`	1.58 MiB	2.20 MiB	635.29 KiB
`604a261`	1.58 MiB	2.10 MiB	533.42 KiB
`806307f`	1.58 MiB	2.10 MiB	533.42 KiB
`22f4345`	1.58 MiB	2.29 MiB	719.83 KiB
`d217708`	1.58 MiB	2.10 MiB	532.97 KiB
`c3ee041`	0 B	0 B	0 B

Previous results on branch: fix/fragment-detach-attach-tracing

Startup times

Revision	Plain	With Sentry	Diff
`7966377`	324.00 ms	379.38 ms	55.38 ms
`c53e6fb`	312.80 ms	372.79 ms	59.99 ms
`be2bf5f`	314.90 ms	364.90 ms	50.00 ms
`e4e78b2`	364.04 ms	473.08 ms	109.04 ms
`43a4db4`	322.81 ms	360.10 ms	37.29 ms

App size

Revision	Plain	With Sentry	Diff
`7966377`	0 B	0 B	0 B
`c53e6fb`	0 B	0 B	0 B
`be2bf5f`	0 B	0 B	0 B
`e4e78b2`	0 B	0 B	0 B
`43a4db4`	0 B	0 B	0 B

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…ment onFragmentCreated is skipped during detach/attach navigation, so the screen name was never updated for re-attached fragments. Mirror the screen tracking into onFragmentViewCreated to cover that path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

0xadam-brown

Nice! A few quick comments; otherwise lgtm 👍

runningcode

Fragments are so confusing! Thanks for the fix.

…ple layout Move isAdded check, screen tracking, and tracing logic into startTracing() to deduplicate guards from onFragmentCreated and onFragmentViewCreated. Fix DetachAttachTabsActivity sample rendering on API 35+ by using NoActionBar theme and fitsSystemWindows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Screen name updates on scope should work independently of whether performance tracing is enabled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

0xadam-brown

Thanks for the updates – lgtm 💯

Format code

d861925

romtsn and others added 3 commits June 30, 2026 15:52

Add changelog entry and detach/attach sample

a783845

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge branch 'main' into fix/fragment-detach-attach-tracing

af34cb1

Remove duplicate test methods in fragment lifecycle test

0412cb7

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

romtsn marked this pull request as ready for review June 30, 2026 15:26

romtsn requested review from 0xadam-brown, adinauer, markushi and runningcode as code owners June 30, 2026 15:26

sentry Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread ...ndroid-fragment/src/main/java/io/sentry/android/fragment/SentryFragmentLifecycleCallbacks.kt Outdated

romtsn and others added 2 commits June 30, 2026 19:25

Format code

27d39bd

0xadam-brown reviewed Jul 1, 2026

View reviewed changes

runningcode approved these changes Jul 1, 2026

View reviewed changes

0xadam-brown reviewed Jul 2, 2026

View reviewed changes

Comment thread ...ndroid-fragment/src/main/java/io/sentry/android/fragment/SentryFragmentLifecycleCallbacks.kt

fix: Decouple screen tracking from performance tracing in fragments

aaeb610

Screen name updates on scope should work independently of whether performance tracing is enabled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

0xadam-brown approved these changes Jul 2, 2026

View reviewed changes

Comment thread ...id-fragment/src/test/java/io/sentry/android/fragment/SentryFragmentLifecycleCallbacksTest.kt

Comment thread ...ndroid-fragment/src/main/java/io/sentry/android/fragment/SentryFragmentLifecycleCallbacks.kt

romtsn merged commit 7d8a394 into main Jul 2, 2026
69 of 70 checks passed

romtsn deleted the fix/fragment-detach-attach-tracing branch July 2, 2026 11:44

Uh oh!

Uh oh!

Conversation

romtsn commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause

Fix

What's new for customers

Tests

Not verified

Uh oh!

sentry Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📲 Install Builds

Android

Uh oh!

github-actions Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: fix/fragment-detach-attach-tracing

Startup times

App size

Uh oh!

Uh oh!

0xadam-brown left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

runningcode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0xadam-brown left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

romtsn commented Jun 29, 2026 •

edited

Loading

sentry Bot commented Jun 29, 2026 •

edited

Loading

github-actions Bot commented Jun 29, 2026 •

edited

Loading