fix(android): Block profiling on unsupported system package - #5975
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
fix(android): Block profiling on unsupported system package#5975sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Markus Hintersteiner <markus.hintersteiner@sentry.io>
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Block profiling on unsupported system package ([#5975](https://github.com/getsentry/sentry-java/pull/5975))If none of the above apply, you can opt out of this check by adding |
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc5ccaf | 279.11 ms | 353.34 ms | 74.23 ms |
| 96eeafa | 361.43 ms | 455.07 ms | 93.63 ms |
| 44472da | 324.77 ms | 360.60 ms | 35.83 ms |
| 694d587 | 305.45 ms | 378.38 ms | 72.94 ms |
| 694d587 | 379.62 ms | 400.80 ms | 21.18 ms |
| bb0ff41 | 321.00 ms | 378.28 ms | 57.28 ms |
| 0d66c0b | 327.83 ms | 403.40 ms | 75.57 ms |
| e2dce0b | 308.96 ms | 360.10 ms | 51.14 ms |
| ce0a49e | 532.00 ms | 609.96 ms | 77.96 ms |
| ad8da22 | 365.86 ms | 427.00 ms | 61.14 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| 96eeafa | 1.58 MiB | 2.19 MiB | 620.21 KiB |
| 44472da | 0 B | 0 B | 0 B |
| 694d587 | 1.58 MiB | 2.19 MiB | 620.06 KiB |
| 694d587 | 1.58 MiB | 2.19 MiB | 620.06 KiB |
| bb0ff41 | 0 B | 0 B | 0 B |
| 0d66c0b | 1.58 MiB | 2.29 MiB | 720.89 KiB |
| e2dce0b | 0 B | 0 B | 0 B |
| ce0a49e | 1.58 MiB | 2.10 MiB | 532.94 KiB |
| ad8da22 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android system package version
370546200can accept profiling requests but produce empty traces. This change resolves the installed profiling package version when the profiler is created and skips profiling for that version.Unknown and other package versions keep the existing behavior.
Tests
JAVA_HOMEis unset andjavais unavailable).git diff --checkpassed.Requested by markus.hintersteiner.
--
View Junior Session [Sentry]