ref(node)!: Consolidate httpIntegration options - #23443
Draft
RulaKhaled wants to merge 3 commits into
Draft
Conversation
Contributor
size-limit report 📦
|
Collaborator
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fc42fd3. Configure here.
Public option names now match httpServerIntegration / httpServerSpansIntegration. Nested instrumentation hooks are first-class outgoing hooks instead of a leftover OTEL-era nest. Fixes #22255
Serverless freeze happens at the end of the incoming request, which onSpanCreated and Nitro's event-handler patch already cover. Flushing again on each outbound response starts extra 2s flushes on platforms without waitUntil.
patchEventHandler already flushes after the Nitro handler. The onSpanCreated hook ran at span start, before the request had events to send. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
RulaKhaled
force-pushed
the
rolaabuhasna/js-3035-consolidate-the-various-http-integration-options-into-one
branch
from
August 19, 2026 08:43
9160cc3 to
0dcceac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #23396. After that lands, this should be rebased onto
develop.httpIntegrationnow uses the same option names ashttpServerIntegration/httpServerSpansIntegrationand the other server SDKs. After #23396, incominginstrumentation.*hooks were already gone; this PR finishes the leftover public API: flatten outgoinginstrumentationinto first-class hooks, and drop the long aliases that only existed onhttpIntegration.Fixes #22255
Why
The public
httpIntegrationsurface had long names (trackIncomingRequestsAsSessions,maxIncomingRequestBodySize, …) mapped 1:1 onto shorter names already used by the sub-integrations, Bun, Deno, and Cloudflare. Those aliases were leftover from the OTEL HttpInstrumentation era; they were never deprecated, and v11 is the point to collapse them rather than carry both.Incoming
instrumentation.{requestHook,responseHook,applyCustomAttributesOnSpan}already all ran at span create after dropping OTEL, which is why #23396 collapsed them toonSpanCreated. Outgoing still has real request vs response timing, so those becomeoutgoingRequestHook/outgoingResponseHook/outgoingRequestApplyCustomAttributesinstead of staying nested.