feat(nextjs): Register a route provider from the build-time route manifest - #23552
Draft
logaretm wants to merge 1 commit into
Draft
feat(nextjs): Register a route provider from the build-time route manifest#23552logaretm wants to merge 1 commit into
logaretm wants to merge 1 commit into
Conversation
14 tasks
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
2 times, most recently
from
August 24, 2026 20:17
737c9cf to
5d8e20b
Compare
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
August 24, 2026 20:52
5d8e20b to
464c7d0
Compare
Both routers already ship a pure matcher: the App Router has the build-time route manifest behind `maybeParameterizeRoute`, and the Pages Router matches against `__BUILD_MANIFEST.sortedPages`. Neither was reachable from anywhere except the pageload and navigation instrumentation. The two want the pathname differently, since App Router routes are generated with `basePath` baked in while Next strips it internally for the Pages Router, so the provider normalizes per manifest.
logaretm
force-pushed
the
awad/route-provider-nextjs
branch
from
August 24, 2026 20:57
464c7d0 to
1eb7910
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a route provider covering both the Next.js App Router and Pages Router.
Both already ship a pure matcher: the App Router has the build-time route manifest behind
maybeParameterizeRoute, and the Pages Router matches against__BUILD_MANIFEST.sortedPages. Neither was reachable from anywhere except the pageload and navigation instrumentation.The two want the pathname differently, since App Router routes are generated with
basePathbaked in while Next strips it internally for the Pages Router, so the provider normalizes per manifest.Part of #23556