Repository navigation
feat(nitro): Merge the nitro integrations into a single nitroIntegration - #25349
Merged
mydea merged 2 commits intoOct 19, 2026
Merged
Conversation
mydea
added this pull request to stack #25350
October 14, 2026 07:32
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fdf4d4b. Configure here.
Contributor
size-limit report 📦
|
mydea
force-pushed
the
feat/nitro-single-integration
branch
from
October 14, 2026 07:43
fdf4d4b to
dece0fa
Compare
mydea
marked this pull request as ready for review
October 14, 2026 07:49
mydea
requested review from
andreiborza,
isaacs,
logaretm,
nicohrubec and
s1gr1d
and removed request for
a team
October 14, 2026 07:49
logaretm
approved these changes
Oct 15, 2026
mydea
force-pushed
the
feat/nitro-single-integration
branch
from
October 16, 2026 06:57
dece0fa to
47f97c8
Compare
…tion` Server-Timing headers were split into a separate default integration because `nitroIntegration` was tracing-gated, while trace propagation must work in tracing-without-performance mode. That split forced a second orchestrion anchor (`unstorage`) for Cloudflare auto-injection, since a module registers a single integration. Register one `nitroIntegration` as a default integration instead (like express/hono/koa, its spans are non-recording without tracing) with `serverTiming` and `storage` options, both enabled by default, to opt out of the Server-Timing headers or the unstorage cache spans. It is anchored on `h3` alone, which every HTTP-serving Nitro app loads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
feat/nitro-single-integration
branch
from
October 19, 2026 07:58
47f97c8 to
2cdaa81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #24861. Replaces #24897.
nitroServerTimingIntegrationonly existed as a separate integration becausenitroIntegrationwas tracing-gated, while Server-Timing trace propagation must work in tracing-without-performance mode. That split meant Cloudflare auto-injection needed a second anchor module (unstorage), since a module registers a single integration, and a Nitro app that never loadedunstoragewould silently lose the headers. #24897 tried to fix that by letting one module register several integrations, which complicated the global marker shape.Instead, there is now a single
nitroIntegrationwith options to opt out of parts of it, both enabled by default:It's registered as a default integration rather than a tracing one, like express/hono/koa: without tracing, the spans it starts are non-recording, and the Server-Timing headers still propagate. It's anchored on
h3alone, which every HTTP-serving Nitro app loads, so the marker keeps its single-factory shape.🤖 Generated with Claude Code