test: Check that runtimes drop the server spans of managed tunnel requests by logaretm · Pull Request #25414 · getsentry/sentry-javascript

logaretm · 2026-10-15T15:33:45Z

Runtimes only translate tunnel: true while meta-frameworks answer the requests, so nothing pinned down that their server spans get dropped.

This PR asserts that runtime SDKs level (Cloudflare, Node, Bun and Deno) ignores the tunneled span so we don't have to chase it around. This is one benefit of having tunnels as a core SDK capability, this PR just tests that.

Node, Deno and Cloudflare live in their integration test suites, and Bun is a unit test in its package.

closes #25462

github-actions · 2026-10-15T15:44:41Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	30.53 kB	+2.18%	+649 B 🔺
@sentry/browser - with treeshaking flags	28.51 kB	+1.75%	+490 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing	28.39 kB	+1.7%	+473 B 🔺
@sentry/browser (incl. Tracing)	52.77 kB	+1.35%	+699 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)	52.77 kB	+1.35%	+698 B 🔺
@sentry/browser (incl. Tracing, Profiling)	55.74 kB	+1.32%	+721 B 🔺
@sentry/browser (incl. Tracing, Replay)	92.44 kB	+0.68%	+616 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	81.18 kB	+0.62%	+496 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)	97.18 kB	+0.66%	+629 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)	110.17 kB	+0.63%	+683 B 🔺
@sentry/browser (incl. Feedback)	48.09 kB	+1.48%	+699 B 🔺
@sentry/browser (incl. sendFeedback)	35.6 kB	+1.9%	+662 B 🔺
@sentry/browser (incl. FeedbackAsync)	40.73 kB	+1.71%	+683 B 🔺
@sentry/browser (incl. Metrics)	31.54 kB	+2.05%	+633 B 🔺
@sentry/browser (incl. Logs)	31.81 kB	+2.01%	+626 B 🔺
@sentry/browser (incl. Metrics & Logs)	32.48 kB	+2.11%	+670 B 🔺
@sentry/react	32.33 kB	+2%	+631 B 🔺
@sentry/react (incl. Tracing)	55.02 kB	+1.17%	+633 B 🔺
@sentry/vue	38.68 kB	+1.7%	+643 B 🔺
@sentry/vue (incl. Tracing)	55.72 kB	+1.31%	+716 B 🔺
@sentry/svelte	30.56 kB	+2.2%	+657 B 🔺
@sentry/remix (Remix 3 client bundle)	57.8 kB	+1.26%	+715 B 🔺
CDN Bundle	32.11 kB	+1.49%	+470 B 🔺
CDN Bundle (incl. Tracing)	53.06 kB	+0.91%	+478 B 🔺
CDN Bundle (incl. Logs, Metrics)	34.31 kB	+1.41%	+474 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)	55.01 kB	+0.89%	+483 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)	75.26 kB	+0.66%	+492 B 🔺
CDN Bundle (incl. Tracing, Replay)	90.73 kB	+0.53%	+478 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	92.66 kB	+0.52%	+479 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)	96.87 kB	+0.49%	+468 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	98.83 kB	+0.5%	+489 B 🔺
CDN Bundle - uncompressed	94.33 kB	+1.24%	+1.15 kB 🔺
CDN Bundle (incl. Tracing) - uncompressed	157.19 kB	+0.74%	+1.15 kB 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed	100.87 kB	+1.16%	+1.15 kB 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	163.14 kB	+0.72%	+1.15 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	230.91 kB	+0.51%	+1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed	277.35 kB	+0.42%	+1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	283.3 kB	+0.41%	+1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	291.06 kB	+0.4%	+1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	296.99 kB	+0.39%	+1.15 kB 🔺
@sentry/nextjs (client)	57.35 kB	+1.09%	+613 B 🔺
@sentry/sveltekit (client)	53.08 kB	+1.2%	+627 B 🔺
@sentry/core/server	42.85 kB	+4.08%	+1.68 kB 🔺
@sentry/core/browser	13.81 kB	-	-
@sentry/node	155.79 kB	+0.42%	+649 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)	84.06 kB	-	-
@sentry/node - without tracing	97.47 kB	+0.69%	+661 B 🔺
@sentry/node - without channel injection	133.8 kB	+0.47%	+623 B 🔺
@sentry/aws-serverless	105.74 kB	+0.69%	+723 B 🔺
@sentry/cloudflare (withSentry) - minified	212.9 kB	+0.96%	+2.01 kB 🔺
@sentry/cloudflare (withSentry)	528.07 kB	+0.94%	+4.9 kB 🔺
@sentry/nextjs/cloudflare (withSentry) - minified	232.52 kB	+0.88%	+2.01 kB 🔺

View base workflow run

logaretm · 2026-10-15T21:56:02Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

logaretm · 2026-10-16T02:14:26Z

bugbot run

logaretm · 2026-10-16T02:14:44Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

JPeer264 · 2026-10-20T12:15:02Z

+
+const DSN = 'https://username@domain/123';
+
+Deno.test('Deno.serve drops the server span of managed tunnel requests', async () => {


q: Do we need this test? Theoretically the node integration tests should run under deno too, so this unit test would be a duplication 🤔

Ah okay, I'm moving both of these tests to their runtime's own tests.

…uests Meta-framework SDKs answer the tunnel requests. Cloudflare, Node, Bun and Deno only translate `tunnel: true` so the core client drops the server span they create for them, which these tests pin down.

…ration tests

…gration test

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 74fe197. Configure here.}

logaretm added this pull request to stack #25201 October 15, 2026 15:33

logaretm force-pushed the awad/tunnel-cloudflare branch from 323db37 to 776be29 Compare October 15, 2026 15:36

logaretm force-pushed the awad/tunnel-cloudflare branch from 776be29 to e0f36f5 Compare October 15, 2026 15:51

logaretm force-pushed the awad/tunnel-cloudflare branch from 4a248fa to 37afe7c Compare October 15, 2026 16:38

logaretm force-pushed the awad/tunnel-cloudflare branch from 37afe7c to 03d8225 Compare October 15, 2026 17:15

logaretm force-pushed the awad/tunnel-cloudflare branch from 03d8225 to 3e455f4 Compare October 15, 2026 17:36

logaretm changed the title ~~feat(cloudflare): Serve the managed tunnel from the request wrapper~~ test: Check that runtimes drop the server spans of managed tunnel requests Oct 15, 2026

logaretm force-pushed the awad/tunnel-cloudflare branch from 3e455f4 to fa2d7a6 Compare October 15, 2026 17:44

logaretm force-pushed the awad/tunnel-cloudflare branch from fa2d7a6 to 034ec1f Compare October 15, 2026 18:16

logaretm force-pushed the awad/tunnel-cloudflare branch from 034ec1f to b254fc1 Compare October 15, 2026 18:26

logaretm force-pushed the awad/tunnel-cloudflare branch from b254fc1 to b8540c7 Compare October 15, 2026 18:28

cursor Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread packages/cloudflare/test/request.test.ts Outdated

Comment thread dev-packages/node-integration-tests/suites/tracing/managed-tunnel/test.ts Outdated

Comment thread dev-packages/node-integration-tests/suites/tracing/managed-tunnel/test.ts

logaretm force-pushed the awad/tunnel-cloudflare branch from b8540c7 to a729215 Compare October 16, 2026 01:51

cursor Bot reviewed Oct 16, 2026

View reviewed changes

logaretm force-pushed the awad/tunnel-cloudflare branch from a729215 to bcba572 Compare October 16, 2026 02:25

logaretm force-pushed the awad/tunnel-cloudflare branch from dba8b7f to 1ca3074 Compare October 19, 2026 17:08

logaretm force-pushed the awad/tunnel-cloudflare branch 2 times, most recently from 52c1093 to 26d2e6e Compare October 19, 2026 18:15

logaretm force-pushed the awad/tunnel-cloudflare branch 2 times, most recently from 2531891 to 5ae1c71 Compare October 19, 2026 18:36

logaretm force-pushed the awad/tunnel-cloudflare branch from 5ae1c71 to 2cd301c Compare October 19, 2026 19:12

logaretm marked this pull request as ready for review October 19, 2026 19:36

logaretm requested a review from a team as a code owner October 19, 2026 19:36

logaretm requested review from JPeer264 and isaacs and removed request for a team October 19, 2026 19:36

logaretm requested review from a team as code owners October 19, 2026 20:07

logaretm requested review from chargome and s1gr1d and removed request for a team October 19, 2026 20:07

JPeer264 approved these changes Oct 20, 2026

View reviewed changes

logaretm added 5 commits October 20, 2026 10:29

test: Check that runtimes drop the server spans of managed tunnel req…

fe6c48c

…uests Meta-framework SDKs answer the tunnel requests. Cloudflare, Node, Bun and Deno only translate `tunnel: true` so the core client drops the server span they create for them, which these tests pin down.

test(bun): Run the managed tunnel suite only with the Bun SDK

bd5d7ab

test(node): Assert the tunnel request sends no server span at all

1884646

test(deno): Move the Deno.serve managed tunnel test to the Deno integ…

e81da25

…ration tests

test(cloudflare): Move the managed tunnel span test to a workerd inte…

74fe197

…gration test

cursor Bot reviewed Oct 20, 2026

View reviewed changes

Comment thread dev-packages/cloudflare-integration-tests/suites/tracing/managed-tunnel/test.ts

Comment thread dev-packages/cloudflare-integration-tests/suites/tracing/managed-tunnel/test.ts

logaretm mentioned this pull request Oct 20, 2026

feat(core): Add managed tunnel helpers that derive the tunnel path from the DSN #25199

Open

Navigation Menu

Repository navigation

test: Check that runtimes drop the server spans of managed tunnel requests - #25414

test: Check that runtimes drop the server spans of managed tunnel requests#25414
logaretm wants to merge 5 commits into
awad/tunnel-tanstackstartfrom
awad/tunnel-cloudflare

logaretm commented Oct 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 15, 2026 •

edited

Loading

Uh oh!

logaretm commented Oct 15, 2026

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

logaretm commented Oct 16, 2026

Uh oh!

logaretm commented Oct 16, 2026

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

JPeer264 Oct 20, 2026

Uh oh!

logaretm Oct 20, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		const DSN = 'https://username@domain/123';

		Deno.test('Deno.serve drops the server span of managed tunnel requests', async () => {

Conversation

logaretm commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

logaretm commented Oct 15, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

logaretm commented Oct 16, 2026

Uh oh!

logaretm commented Oct 16, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JPeer264 Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

logaretm Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

logaretm commented Oct 15, 2026 •

edited

Loading

github-actions Bot commented Oct 15, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading