Repository navigation
Conversation
The @Cron and @interval handlers throw the same error on every tick, so the Dedupe integration drops all but the first one unless another error is sent in between. Once the other erroring cron jobs are killed, that first error can predate the test's listener and it times out. Allow `waitForError` to look back like `waitForStreamedSpan` and use it here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Include a timestamp in the thrown errors so the Dedupe integration never drops them, and only accept errors thrown after the test started. This reverts the `waitForError` timestamp option. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
marked this pull request as ready for review
October 19, 2026 08:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@Interval(and@Cron) handlers innestjs-basicthrew an identical error on every tick, and theDedupeintegration drops consecutive identical errors. Once earlier tests have killed the other erroring cron jobs, nothing interleaves, so only the first interval error is ever sent — often before the test starts listening — andwaitForErrortimes out.The handlers now include
Date.now()in the error message so every tick produces a distinct error, and the tests only accept an error thrown after the test started.🤖 Generated with Claude Code