Repository navigation
fix(v10/browser): Skip profiling for unsampled active root spans - #25502
Merged
Lms24 merged 1 commit intoOct 19, 2026
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
approved these changes
Oct 19, 2026
Lms24
marked this pull request as ready for review
October 19, 2026 08:03
Lms24
requested review from
logaretm and
mydea
and removed request for
a team
October 19, 2026 08:03
Lms24
enabled auto-merge (squash)
October 19, 2026 08:06
Lms24
deleted the
backport/v10-25498-browser-profiling-unsampled-root-span
branch
October 19, 2026 08:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25498
Differences to the original PR
packages/browser/test/profiling/integration.test.ts: the two new tests use v10's existingimport * as Sentry from '@sentry/browser'style (Sentry.init,Sentry.addIntegration, etc.) instead of named imports from../../src/index. That import block conflicted because v10's test file still uses the namespace import.Sentry.spanToJSONinstead ofspanToStaticSpanJSON, becausespanToStaticSpanJSONdoesn't exist on v10.The source change in
UIProfiler.tsis identical to the original.via Junior system actor
junior.--
View Junior Session [Sentry]