Repository navigation
feat(bun): Add incoming request options and sessions to bunServerIntegration - #25580
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7e82d34. Configure here.
3563640 to
d84e648
Compare
d84e648 to
3563640
Compare
…egration` `Bun.serve` took only `maxRequestBodySize`. A user could not skip body capture or spans for one route, and release health showed no request sessions or crash-free rate for `Bun.serve` apps. `denoServeIntegration` got these in #25493 and #25496. `bunServerIntegration` now accepts `ignoreRequestBody`, `ignoreIncomingRequests`, `ignoreStaticAssets`, `spans`, `onSpanCreated`, `onSpanEnd`, `sessions` and `sessionFlushingDelayMS`. They use the same names and behavior as `denoServeIntegration`, and the callbacks receive the web `Request`. The shared `ServerRequestOptions` check for `Bun.serve` now lists no unsupported options. When the SDK skips the span, it still continues the incoming trace, attaches request data and the body, records the session and captures errors. For a streamed response, `onSpanEnd` and the session end when the stream finishes. A user callback that throws does not fail the request. If `ignoreRequestBody` throws, the SDK skips the body, so it cannot leak data that the filter was meant to hide. Three changes in behavior: - `ignoreStaticAssets` defaults to `true`, so `GET` requests for files such as `favicon.ico` or `*.js` no longer create spans. - `spans` defaults to the client's tracing configuration, so the integration no longer starts spans when tracing is disabled. - Errors thrown for `OPTIONS` and `HEAD` requests are now captured. These requests also record sessions, as on Node and Deno. Fixes #25571 Fixes JS-3969 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
3563640 to
bdaba32
Compare
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
Nice addition, just have two questions
| } | ||
| } | ||
|
|
||
| function shouldCreateSpan( |
There was a problem hiding this comment.
m: Do we want to have behavior changes of that sort in a minor? I understand that this might fill the gap between Node&Deno, but I don't think this should land in a minor. Wdyt?
From the 3 points you brought up in the PR description, only the first looks like a breaking for spans.
| request: Request, | ||
| urlPath: string, | ||
| ): boolean { | ||
| if (!(integration?.spans ?? (client ? hasSpansEnabled(client.getOptions()) : false))) { |
There was a problem hiding this comment.
m: I had once a discussion with @andreiborza that, even if spans are turned off, that we still generate spans, as they generate NonRecordingSpans. (I'm personally for the skipping if off). Not sure if we have a specific rule when it's acceptable and when not. Maybe @andreiborza could elaborate here
There was a problem hiding this comment.
I think it's fine here because it's wrapped in continueTrace already. If we didn't have that it would be a problem because it would break TwP (Tracing without Performance) but as far as I can see here it's not the case because we specifically continue the trace.
This branch has not been deployed
3 participants
Bun.servetook onlymaxRequestBodySize. A user could not skip body capture or spans for one route, and release health showed no request sessions or crash-free rate forBun.serveapps.denoServeIntegrationgot these in #25493 and #25496.bunServerIntegrationnow acceptsignoreRequestBody,ignoreIncomingRequests,ignoreStaticAssets,spans,onSpanCreated,onSpanEnd,sessionsandsessionFlushingDelayMS. They use the same names and behavior asdenoServeIntegration, and the callbacks receive the webRequest. The sharedServerRequestOptionscheck forBun.servenow lists no unsupported options.When the SDK skips the span, it still continues the incoming trace, attaches request data and the body, records the session and captures errors. For a streamed response,
onSpanEndand the session end when the stream finishes. A user callback that throws does not fail the request. IfignoreRequestBodythrows, the SDK skips the body, so it cannot leak data that the filter was meant to hide.Three changes in behavior:
ignoreStaticAssetsdefaults totrue, soGETrequests for files such asfavicon.icoor*.jsno longer create spans.spansdefaults to the client's tracing configuration, so the integration no longer starts spans when tracing is disabled.OPTIONSandHEADrequests are now captured. These requests also record sessions, as on Node and Deno.Fixes #25571
Fixes JS-3969