Repository navigation
feat(node): Add onSpanEnd to httpIntegration - #25581
Open
Conversation
isaacs
added this pull request to stack #25589
October 20, 2026 22:30
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cc344a9. Configure here.
isaacs
marked this pull request as ready for review
October 20, 2026 23:56
isaacs
requested review from
JPeer264 and
andreiborza
and removed request for
a team
October 20, 2026 23:56
Contributor
size-limit report 📦Compared: 779cfe2 (PR test merge using develop at e196565) Against: 6fb6b07 (develop) · base run #62924
|
isaacs
force-pushed
the
isaacschlueter/js-3970-node-add-onspanend-to-httpintegration
branch
from
October 21, 2026 01:07
45ebb10 to
1f0fc7f
Compare
isaacs
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
October 21, 2026 01:12
isaacs
force-pushed
the
isaacschlueter/js-3970-node-add-onspanend-to-httpintegration
branch
from
October 21, 2026 01:12
1f0fc7f to
4e495ab
Compare
isaacs
force-pushed
the
isaacschlueter/js-3970-node-add-onspanend-to-httpintegration
branch
from
October 21, 2026 01:15
4e495ab to
35530ea
Compare
This was referenced Oct 21, 2026
JPeer264
approved these changes
Oct 21, 2026
| span_id: expect.stringMatching(/[a-f\d]{16}/), | ||
| trace_id: expect.stringMatching(/[a-f\d]{32}/), | ||
| status: 'ok', | ||
| attributes: expect.objectContaining({ |
Member
There was a problem hiding this comment.
l: Since it was already here actually ok, but maybe we can remove the expect.objectContaining entirely, then this would even fail if we forget to add new attributes
Suggested change
| attributes: { |
`httpIntegration` takes `onSpanCreated` for incoming requests, but not `onSpanEnd`. A user could not change the server span based on the response, for example to rename it from data that is only known when the response finishes. Core's `node:http` server code already supports `onSpanEnd`, and `denoHttpIntegration` and `bunHttpServerIntegration` pass it through. `httpServerSpansIntegration` now accepts `onSpanEnd` and calls it as core does: when the response finishes, after the SDK sets the response attributes and the span status, before the span ends. `httpIntegration` passes it through. The shared `ServerRequestOptions` check for Node now lists no unsupported options. Fixes #25572 Fixes JS-3970 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
isaacs
force-pushed
the
isaacschlueter/js-3970-node-add-onspanend-to-httpintegration
branch
from
October 21, 2026 14:16
35530ea to
81d2783
Compare
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 3 failing, 47 successful. See the run.
Successful checks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpIntegrationtakesonSpanCreatedfor incoming requests, but notonSpanEnd. A user could not change the server span based on the response, for example to rename it from data that is only known when the response finishes. Core'snode:httpserver code already supportsonSpanEnd, anddenoHttpIntegrationandbunHttpServerIntegrationpass it through.httpServerSpansIntegrationnow acceptsonSpanEndand calls it as core does: when the response finishes, after the SDK sets the response attributes and the span status, before the span ends.httpIntegrationpasses it through. The sharedServerRequestOptionscheck for Node now lists no unsupported options.Fixes #25572
Fixes JS-3970