Skip to content

test(aws-serverless): Allow timer skew in callback-style handler duration assertions #25608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mydea wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −2
Open

test(aws-serverless): Allow timer skew in callback-style handler duration assertions #25608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dev-packages/e2e-tests/test-applications/aws-serverless-layer/tests/layer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,9 @@ test.describe('Lambda layer', () => {
const transactionEvent = await transactionEventPromise;

expect(transactionEvent.contexts?.trace?.status).toBe('ok');
expect(transactionEvent.timestamp! - transactionEvent.start_timestamp!).toBeGreaterThanOrEqual(0.2);
// The span clock and the 200ms callback timer can disagree by a few ms. A span that ended when the
// handler returned would be near 0, so this margin still catches it.
expect(transactionEvent.timestamp! - transactionEvent.start_timestamp!).toBeGreaterThanOrEqual(0.15);
});

test('sets error status when a callback-style handler calls back with an error after it returned', async ({
Expand All @@ -360,7 +362,7 @@ test.describe('Lambda layer', () => {
const [errorEvent, transactionEvent] = await Promise.all([errorEventPromise, transactionEventPromise]);

expect(transactionEvent.contexts?.trace?.status).toBe('internal_error');
expect(transactionEvent.timestamp! - transactionEvent.start_timestamp!).toBeGreaterThanOrEqual(0.2);
expect(transactionEvent.timestamp! - transactionEvent.start_timestamp!).toBeGreaterThanOrEqual(0.15);
expect(errorEvent.contexts?.trace?.trace_id).toBe(transactionEvent.contexts?.trace?.trace_id);
});

Expand Down
Loading