Repository navigation
fix(v10/server-utils): Bundle the CommonJS dependencies of instrumented packages on Vite 8 - #25704
Draft
nicohrubec wants to merge 2 commits into
Draft
nicohrubec wants to merge 2 commits into
nicohrubec wants to merge 2 commits into
Conversation
…ed packages on Vite 8 Backport of: #25523 Co-Authored-By: GPT-6 <codex@openai.com>
Contributor
size-limit report 📦
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25523
Differences to the original PR
@sentry/*) retain their existing resolution so this change cannot bundle an extra SDK copy; added three regressions for these imports. The resolver only activates for Rolldown build-time require calls, preserving Vite 6/7 behavior.tanstackstart-react-orchestrionE2E app. The ordinary app does not run the orchestrion plugin on v10. The assertion checks emitted specifiers directly because v10's test-utils do not exportbundleReferencesModule.Fixes #25470
All 40 resolver/plugin tests pass, as do scoped lint and a type check against Vite 6. Repository-wide formatting passes; lint/build still fail on unrelated baseline/type mismatches. The deployed E2E app was not run locally.