Repository navigation
fix(v10/hono): Read connection info from the runtime instead of Hono helpers - #25707
Draft
nicohrubec wants to merge 2 commits into
Draft
nicohrubec wants to merge 2 commits into
nicohrubec wants to merge 2 commits into
Conversation
…helpers Backport of: #25552 Co-Authored-By: GPT-6 <codex@openai.com>
Contributor
size-limit report 📦
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25552
Differences to the original PR
packages/hono/src/shared/, using Hono's existingContexttype and v10'sspanToJSON(...).data. Wired the runtime name into the four existing middleware implementations without porting v11's shared server-utils integration or changing public options/init behavior.getClientIPAddress, allowing the original@sentry/core/serverimport to reuse its forwarding-header parser without duplication.@hono/node-serverdependency metadata to avoid unrelated dependency-file changes. Runtime imports of the helper are removed.All 266 Hono unit tests, Hono/core type checking, formatting and scoped lint pass. Repository-wide lint/build still encounter unrelated baseline/type mismatches. Runtime deployment E2E tests were not run locally.