Repository navigation
fix(v10/cloudflare): Keep draining after a synchronous transport error - #25709
Draft
nicohrubec wants to merge 2 commits into
Draft
nicohrubec wants to merge 2 commits into
nicohrubec wants to merge 2 commits into
Conversation
Backport of: #25374 Co-Authored-By: GPT-6 <codex@openai.com>
Contributor
size-limit report 📦
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25374
Differences to the original PR
IsolatedPromiseBuffer.drain()guard and its regression, unchanged from the original. A synchronous request failure no longer stops other queued requests from being sent.All 15 transport tests pass. The regression fails against the original v10 transport and passes with this fix. Cloudflare type checking, formatting and scoped lint pass; repository-wide lint/build still encounter unrelated baseline/type mismatches.