Skip to content

fix(crashpad): preserve UUIDs from minimal PDB70 records - #2003

Open
jpnurmi wants to merge 6 commits into
masterfrom
jpnurmi/fix/crashpad-codeview
Open

fix(crashpad): preserve UUIDs from minimal PDB70 records#2003
jpnurmi wants to merge 6 commits into
masterfrom
jpnurmi/fix/crashpad-codeview

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Reproduces #2002 with the MinGW CI job:

>       codeview = codeviews[module_name]
                   ^^^^^^^^^^^^^^^^^^^^^^
E       KeyError: 'sentry.dll'

tests\test_integration_crashpad.py:114: KeyError

Proposed fix:

Close: #2002

Parse module CodeView records from uploaded minidumps and assert the
example module carries a non-zero UUID.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9383db2. Configure here.

Comment thread tests/test_integration_crashpad.py Outdated
Target the SDK shared library and accept both PDB70 and ELF build-ID
record signatures.
Comment thread tests/assertions.py Outdated
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.47%. Comparing base (85b229c) to head (689e067).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2003      +/-   ##
==========================================
+ Coverage   74.41%   74.47%   +0.06%     
==========================================
  Files         104      104              
  Lines       25913    25913              
  Branches     4691     4691              
==========================================
+ Hits        19282    19299      +17     
+ Misses       5299     5275      -24     
- Partials     1332     1339       +7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpnurmi jpnurmi changed the title [WIP] fix(crashpad): module CodeView UUID fix(crashpad): preserve UUIDs from minimal PDB70 records Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crashpad discards the CodeView record of every MinGW/lld module, so minidumps carry no debug id

1 participant