Repository navigation
chore: Remove include_local_variables, include_source_context - #7867
sentrivana merged 6 commits into
Conversation
Codecov Results 📊✅ 56514 passed | ⏭️ 2727 skipped | Total: 59241 | Pass Rate: 95.4% | Execution Time: 154m 55s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2074 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.38% 90.00% -0.38%
==========================================
Files 202 185 -17
Lines 26552 20731 -5821
Branches 9858 7152 -2706
==========================================
+ Hits 23997 18657 -5340
- Misses 2555 2074 -481
- Partials 1487 1204 -283Generated by Codecov Action |
| """Check if abs_path is actually an absolute path. This can happen either | ||
| with eval/exec like here, or when the file in the frame is relative to | ||
| __main__""" | ||
| sentry_init() |
There was a problem hiding this comment.
I've added these sentry_init() calls to multiple tests -- without them, data_collection would not be resolved and the config wouldn't be taken into account
| ), | ||
| ], | ||
| ) | ||
| def test_include_source_context_when_serializing_frame( |
There was a problem hiding this comment.
This is already extensively tested above
sentrivana
changed the title
include_local_variables, include_source_context
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e46f50c. Configure here.
| dc_stack_frame_vars_config = client_options["data_collection"][ | ||
| "stack_frame_variables" | ||
| ] | ||
| dc_stack_frame_vars_config = data_collection["stack_frame_variables"] |
There was a problem hiding this comment.
Frame serialization crashes without client
High Severity
serialize_frame now always reads data_collection from get_client(). When the SDK is not initialized, that client is a NonRecordingClient whose data_collection is None, so subscripting it raises TypeError. The old include_local_variables and include_source_context defaults no longer cover this path, so event_from_exception and exceptions_from_error_tuple can fail on any exception that has a traceback.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e46f50c. Configure here.
) They're superseded by data collection. Closes https://linear.app/getsentry/issue/PY-2887/dropdeprecate-options-superseded-by-data-collection
2 participants
They're superseded by data collection.
Closes https://linear.app/getsentry/issue/PY-2887/dropdeprecate-options-superseded-by-data-collection