Repository navigation
fix(explore): Pass caseInsensitive through to ExploreFieldValue - #129188
Merged
Merged
Conversation
Co-Authored-By: Josh Ghoulberg <joshua.goldberg@sentry.io>
github-actions
Bot
added
the
Scope: Frontend
JoshuaKGoldberg
enabled auto-merge (squash)
October 29, 2026 14:42
JoshuaKGoldberg
approved these changes
Oct 29, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the frontend build on master after #126977.
That PR moved the value rendering out of
BaseExploreFieldRendererand into a newExploreFieldValuecomponent. Meanwhile, a separate change landed that reads a per-querycaseInsensitiveprop. After the two merged,ExploreFieldValuestill referencedqueryCaseInsensitive, but that variable only exists in the parent's props. This broketscand threwReferenceError: queryCaseInsensitive is not definedin Jest across the explore and metrics specs.This PR passes the prop down to
ExploreFieldValue. When a query sets a value, it still wins over the page-level case-insensitivity setting.via Josh Goldberg.
--
View Junior Session [Sentry]