fix(api): accept null legacy event context - #1353
Merged
Merged
Conversation
betegon
marked this pull request as ready for review
October 1, 2026 11:34
betegon
force-pushed
the
bt/fix-null-event-context
branch
from
October 1, 2026 14:52
a43730f to
c107e0a
Compare
Allow event responses with explicitly null extra data to load issue details while retaining validation of arrays, scalars, and other event fields. Co-Authored-By: Codex (GPT-6) <noreply@openai.com>
betegon
force-pushed
the
bt/fix-null-event-context
branch
from
October 5, 2026 10:33
c107e0a to
10db79e
Compare
5 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event responses can contain
context: nullfor legacy extra data. MCP rejected those responses beforeget_issue_detailscould return the event's error and stacktrace.Accept null in the shared event schema, preserve validation for records and other fields, and keep the existing formatter behavior that omits empty extra data. Regression tests cover the API client and issue-details handler, including safe diagnostics for other validation failures.
Validation
pnpm run tscandpnpm run lintpass.pnpm run testpasses in Linux x64 with Node 24 and UTC.The documentation update selects all workspace projects in CI, exercising the monorepo build and package checks.
CI: all builds, MCP tests, CLI unit/E2E tests, CLI package/runtime checks, and the clean stdio consumer pass. The CLI and CLI docs jobs fail only their generated-file checks: the existing period-help generator uses the current month in examples, changing ten generated references. That date-dependent output is separate from this event-schema fix.