Use git-pkgs clone for HTTPS remotes - #142
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates remote source resolution to use github.com/git-pkgs/clone for HTTPS remotes (with retries, safer URL handling, and optional caching) while retaining direct git clone for non-HTTPS sources, and wires a new --cache flag through the CLI.
Changes:
- Route
https://clones throughgit-pkgs/clone(Ensure) and add an optional persistent cache (Cache.Prepare). - Add
--cacheflag toscan,enrich, andoutline, and plumb it intoremote.Options. - Add unit tests covering HTTPS/non-HTTPS routing, depth mapping, cache behavior, and cleanup on failures.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| remote/remote.go | Switch HTTPS cloning to git-pkgs/clone, introduce cache support, keep git clone for non-HTTPS. |
| remote/remote_test.go | Add tests for Resolve/clone behaviors (HTTPS shallow/full mapping, cache, cleanup, non-HTTPS fallback). |
| README.md | Document new --cache flag for remote sources. |
| cmd/brief/main.go | Add --cache flag to scan and pass through to remote.Resolve. |
| cmd/brief/enrich.go | Add --cache flag to enrich and pass through to remote.Resolve. |
| cmd/brief/outline.go | Add --cache flag to outline and pass through to remote.Resolve. |
| go.mod | Add github.com/git-pkgs/clone v0.5.0 dependency. |
| go.sum | Add checksums for github.com/git-pkgs/clone v0.5.0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
andrew
force-pushed
the
issue-132-clone
branch
from
August 19, 2026 15:18
ab000b3 to
b6a67bc
Compare
andrew
force-pushed
the
issue-132-clone
branch
from
August 19, 2026 15:49
b6a67bc to
d3e8f79
Compare
andrew
force-pushed
the
issue-132-clone
branch
from
August 19, 2026 15:56
d3e8f79 to
23f30be
Compare
andrew
force-pushed
the
issue-132-clone
branch
from
August 19, 2026 16:00
23f30be to
5c99c5b
Compare
andrew
force-pushed
the
issue-132-clone
branch
from
August 19, 2026 16:15
5c99c5b to
9cc4e1f
Compare
andrew
force-pushed
the
issue-132-clone
branch
from
August 19, 2026 16:29
9cc4e1f to
05cdf6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes HTTPS repositories through github.com/git-pkgs/clone v0.5.0 while retaining the existing git command path for SSH-style sources. Maps depth zero to full clones, keeps positive depths shallow, and adds an optional persistent cache for scan, enrich, and outline. Closes #132.