(14) dpdk: RX metadata - #1877
Open
daniel-noland wants to merge 1 commit into
Open
daniel-noland wants to merge 1 commit into
daniel-noland wants to merge 1 commit into
Conversation
daniel-noland
requested review from
Fredi-raspall
and removed request for
a team
October 3, 2026 05:32
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthrough
ChangesMbuf receive accessors
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This PR adds read-only accessors for receive flags, RSS hashes, flow marks and flow metadata on Mbuf. Each accessor returns a value only when its validity condition is met. No merge-blocking risk was found. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
daniel-noland
commented
Oct 3, 2026
Comment on lines
+502
to
+505
| pub fn ol_flags(&self) -> u64 { | ||
| // SAFETY: `self.raw` is a live mbuf for the lifetime of `&self`. | ||
| unsafe { self.raw.as_ref() }.ol_flags | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
this should likely return a stronger type. A bitfield enum or some such
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
daniel-noland
added this pull request to stack #1882
October 3, 2026 06:00
daniel-noland
added
the
area/dpdk
daniel-noland
force-pushed
the
split/dpdk-core/03-buffers
branch
from
October 3, 2026 20:12
bc9de15 to
56039b8
Compare
daniel-noland
removed this pull request from stack #1882
October 3, 2026 21:41
daniel-noland
force-pushed
the
split/dpdk-core/03-buffers
branch
from
October 3, 2026 21:45
56039b8 to
996c9bc
Compare
daniel-noland
force-pushed
the
split/dpdk-core/04-rx-metadata
branch
from
October 3, 2026 23:39
113667a to
2163a66
Compare
daniel-noland
changed the base branch from
split/dpdk-core/03-buffers
to
split/dpdk-core/03b-segments
October 3, 2026 23:39
`Mbuf::ol_flags`, `rss_hash`, `rx_mark` and `rx_meta` read what the NIC reported for a received packet, each gated on the flag that certifies it: `RTE_MBUF_F_RX_RSS_HASH` for the RSS hash, `RTE_MBUF_F_RX_FDIR_ID` for a flow `MARK`, and the registered dynamic-field mask for flow `META`, which reads `None` until `rte_flow_dynf_metadata_register` has succeeded. These are how software sees what flow rules did to a packet, which is what the flow API that follows needs to be observed at all. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>
daniel-noland
force-pushed
the
split/dpdk-core/03b-segments
branch
from
October 4, 2026 06:05
ab54519 to
4d77831
Compare
daniel-noland
force-pushed
the
split/dpdk-core/04-rx-metadata
branch
from
October 4, 2026 06:05
2163a66 to
984402b
Compare
daniel-noland
changed the base branch from
split/dpdk-core/03b-segments
to
pr/daniel-noland/dataplane-perf
October 4, 2026 06:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that (some of) the coverage report for this is empty.
Fixing that in a practical way requires n-vm or (in some cases) hardware. That is fine, it just arrives later in the stack (minus the hardware bit). I may be able to pull those tests back here. Still working on that. That said, the logic itself is ready for review