(04) net: single-segment packet guards and mbuf tail edits - #1883
Open
daniel-noland wants to merge 3 commits into
Open
daniel-noland wants to merge 3 commits into
daniel-noland wants to merge 3 commits into
Conversation
daniel-noland
requested review from
Fredi-raspall
and removed request for
a team
October 3, 2026 21:45
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
daniel-noland
changed the title
daniel-noland
force-pushed
the
split/dpdk-core/03b-segments
branch
from
October 3, 2026 23:18
4faf099 to
ab54519
Compare
Use PacketLength for whole-packet sizing; AsRef exposes only the contiguous head segment. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>
Tailroom, append, and trim-from-end now act on the last segment and return that segment, matching DPDK. Add native mbuf tests for chained edits, deep copies, and packet integration. Co-authored-by: Codex <codex@openai.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>
Packet checksums and TAP reads and writes see only the head segment, so a chained buffer would be checksummed or written truncated, and a TAP read could panic trimming across segments. Reject chains in Packet::new and TapDevice until chained packets are supported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Daniel Noland <daniel@githedgehog.com>
daniel-noland
force-pushed
the
split/dpdk-core/03-buffers
branch
from
October 4, 2026 06:05
996c9bc to
545f4e9
Compare
daniel-noland
force-pushed
the
split/dpdk-core/03b-segments
branch
from
October 4, 2026 06:05
ab54519 to
4d77831
Compare
daniel-noland
changed the title
daniel-noland
added
the
area/dpdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distinguish whole-packet length (
PacketLength) from the contiguous head segment exposed byAsRef.Mbuftailroom, append, and trim-from-end act on the last segment, matching DPDK. Based on #1876.Packets are single-segment for now: checksums and TAP I/O read only the head segment, so
Packet::newandTapDevicereject chained buffers. Buffers are sized to the MTU instead of chaining.TestBufferstays flat.Chained-packet support (a segment-chain
TestBuffer, chunk-aware checksums, chain-on-write) is deferred until we can measure buffer sizing and TX fast-free on the bench.Adds native DPDK tests for chained mbuf edits, deep copies, allocation failure, chain rejection, and packet integration, including generated edit sequences checked against a byte model.
🤖 Generated with Claude Code