Skip to content

feat(scale-set): wire orchestration through runner config - #5350

Merged
edersonbrilhante merged 14 commits into
feat-scale-set-terraformfrom
feat-scale-set-terraform-wiring
Sep 17, 2026
Merged

edersonbrilhante merged 14 commits into
feat-scale-set-terraformfrom
feat-scale-set-terraform-wiring

Conversation

@edersonbrilhante

@edersonbrilhante edersonbrilhante commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description

Wire scale-set orchestration through the provider-aware Terraform composition.

  • Resolve global and per-lane scale-set settings into the canonical runner configuration.
  • Route scale-set lanes through runner-config and the scale-set orchestration provider.
  • Extend the EC2 provider contract with the scale-set runtime configuration, IAM fragments, and outputs consumed by the controller.
  • Gate webhook resources by the selected orchestration provider.
  • Add scale-set validation and Terraform coverage across the affected modules.

This PR provides the Terraform wiring used by the scale-set example and the later MiniStack integration PRs.

Test Plan

  • Terraform formatting, validation/TFLint, and merge-conflict checks passed through the repository hooks.
  • Scale-set routing and configuration-resolution tests passed.
  • Multi-runner and runner-config scale-set Terraform tests passed.
  • Native provider tests remain subject to the local macOS arm64 plugin-handshake limitation.

Related Issues

Depends on #5299.

@edersonbrilhante
edersonbrilhante requested review from a team as code owners September 3, 2026 21:46
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@edersonbrilhante
edersonbrilhante marked this pull request as draft September 3, 2026 22:14
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform-wiring branch from 5be8cd2 to 6c83360 Compare September 3, 2026 22:18
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform-wiring branch from 9c1551f to 90e7cc3 Compare September 4, 2026 18:17
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform-wiring branch from 5b766c7 to addf95c Compare September 4, 2026 19:57
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform-wiring branch from 7b1873a to e35c2e8 Compare September 4, 2026 20:06
@edersonbrilhante
edersonbrilhante marked this pull request as ready for review September 4, 2026 21:39
@edersonbrilhante
edersonbrilhante marked this pull request as draft September 4, 2026 21:39
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform-wiring branch from df08bc9 to c8030e4 Compare September 8, 2026 11:15
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform-wiring branch from a7eaaaa to 619ecf1 Compare September 8, 2026 11:23
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform branch 2 times, most recently from f9254f6 to 67a9230 Compare September 8, 2026 15:41
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform-wiring branch from 619ecf1 to a93e5bd Compare September 8, 2026 15:41
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform branch 2 times, most recently from c20ffc6 to 32f60af Compare September 8, 2026 19:41
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform-wiring branch from 34ff2f0 to 34ef055 Compare September 8, 2026 19:46
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform-wiring branch from 34ef055 to 18dd697 Compare September 8, 2026 19:52
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform-wiring branch from 7cf6156 to a8e4979 Compare September 15, 2026 09:53
@edersonbrilhante
edersonbrilhante marked this pull request as ready for review September 15, 2026 09:53
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform-wiring branch 3 times, most recently from edf27d6 to c0b3717 Compare September 15, 2026 13:48
@edersonbrilhante
edersonbrilhante removed this pull request from stack #5406 September 15, 2026 13:54
@edersonbrilhante
edersonbrilhante added this pull request to stack #5431 September 15, 2026 13:55
@edersonbrilhante
edersonbrilhante force-pushed the feat-scale-set-terraform-wiring branch 4 times, most recently from 7a482a6 to 70c4bfa Compare September 15, 2026 17:58

@guicaulada guicaulada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work wiring this together! Looks good overall, but we should handle the case where the installation ID is omitted. I’ve left a comment inline.

Comment thread modules/multi-runner/orchestration-provider.scale-set.tf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants