Skip to content

docs: localize Korean workshop content and sidebar - #201

Merged
jamesmontemagno merged 4 commits into
github-samples:mainfrom
justinyoo:justinyoo-korean-localization
Oct 13, 2026
Merged

jamesmontemagno merged 4 commits into
github-samples:mainfrom
justinyoo:justinyoo-korean-localization

Conversation

@justinyoo

Copy link
Copy Markdown
Contributor

Adds Korean translations for missing first-steps and real-world-development pages, aligns existing Korean CLI pages with the current lesson sequence, and updates Korean landing links. Localizes the manually maintained Starlight sidebar for Korean readers while preserving route URLs.

Type of change

  • Workshop content (lesson Markdown, images)
  • Site shell (website/ Astro + Starlight wrapper)
  • Copilot configuration (.github/copilot-instructions.md, instructions, agents, skills)
  • Repo housekeeping (CI, dependabot, README, license)
  • Other:

Verification

  • Type checks and a clean site build pass.
  • Affected pages and translations match their source and intended routes.
  • Offline internal link checks pass.
  • Changed external links have been checked separately. N/A: no external link targets changed.

Executed bash .github/skills/build-and-verify-docs/scripts/verify.sh - passed (type checks, production build, and offline Lychee validation).

Screenshots

N/A - text and navigation localization only.

Notes for reviewers

The previously translated CLI pages used obsolete filenames, so they were replaced with the current numbered lessons. The optional Foundry lessons and their links are preserved. Official product names and external link targets remain unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d99bfcc6-2569-40a3-a82a-b81a12e648c6
Copilot AI balanced review requested due to automatic review settings October 13, 2026 12:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The cloud-agent sequence contains an incorrect VS Code workflow, and renamed Korean lesson URLs lack redirects.

4 open findings
What changed in this PR

Adds Korean translations for missing workshop content, updates the Korean CLI lesson sequence, and localizes Starlight navigation.

Changes:

  • Adds Korean VS Code, cloud-agent, and Pages deployment lessons.
  • Replaces obsolete Korean CLI lessons with the current workflow.
  • Updates Korean landing links, Foundry references, and sidebar labels.
File Description
docs/​ko-kr/​README.md Fixes the real-world development link.
docs/​ko-kr/​first-steps/​copilot-app/​12-deploy-pages.md Adds the Korean Pages deployment lesson.
docs/​ko-kr/​real-world-development/​README.md Adds the Korean category landing page.
docs/​ko-kr/​real-world-development/​vscode/​README.md Expands the VS Code title.
docs/​ko-kr/​real-world-development/​vscode/​0-prerequisites.md Adds Korean prerequisites.
docs/​ko-kr/​real-world-development/​vscode/​1-custom-instructions.md Adds the custom-instructions lesson.
docs/​ko-kr/​real-world-development/​vscode/​2-agent-mode.md Adds the agent-mode lesson.
docs/​ko-kr/​real-world-development/​vscode/​3-mcp.md Adds the Playwright MCP lesson.
docs/​ko-kr/​real-world-development/​vscode/​4-custom-agents.md Adds the custom-agents lesson.
docs/​ko-kr/​real-world-development/​vscode/​5-managing-agents.md Adds the agent-management lesson.
docs/​ko-kr/​real-world-development/​vscode/​6-iterating.md Updates the CLI cross-reference.
docs/​ko-kr/​real-world-development/​cloud/​README.md Adds the cloud-agent overview.
docs/​ko-kr/​real-world-development/​cloud/​0-prerequisites.md Adds Korean prerequisites.
docs/​ko-kr/​real-world-development/​cloud/​1-custom-instructions.md Adds the custom-instructions lesson.
docs/​ko-kr/​real-world-development/​cloud/​2-cloud-agent.md Adds the cloud-agent workflow lesson.
docs/​ko-kr/​real-world-development/​cloud/​3-custom-agents.md Adds the custom-agent lesson.
docs/​ko-kr/​real-world-development/​cloud/​4-managing-agents.md Adds the agent-management lesson.
docs/​ko-kr/​real-world-development/​cloud/​5-iterating.md Adds the review and iteration lesson.
docs/​ko-kr/​real-world-development/​cli/​README.md Updates the CLI lesson index.
docs/​ko-kr/​real-world-development/​cli/​0-prerequisites.md Refreshes CLI setup instructions.
docs/​ko-kr/​real-world-development/​cli/​1-install-copilot-cli.md Refreshes installation and authentication.
docs/​ko-kr/​real-world-development/​cli/​2-custom-instructions.md Removes the obsolete lesson.
docs/​ko-kr/​real-world-development/​cli/​2-add-star-rating.md Adds the star-rating lesson.
docs/​ko-kr/​real-world-development/​cli/​3-generating-code.md Removes the obsolete lesson.
docs/​ko-kr/​real-world-development/​cli/​3-agent-modes.md Adds Plan and Autopilot guidance.
docs/​ko-kr/​real-world-development/​cli/​4-mcp.md Removes the obsolete lesson.
docs/​ko-kr/​real-world-development/​cli/​4-custom-instructions.md Adds the revised instructions lesson.
docs/​ko-kr/​real-world-development/​cli/​5-agent-skills.md Updates the quality-checks skill lesson.
docs/​ko-kr/​real-world-development/​cli/​6-custom-agents.md Removes the obsolete lesson.
docs/​ko-kr/​real-world-development/​cli/​6-mcp-playwright.md Adds the revised MCP lesson.
docs/​ko-kr/​real-world-development/​cli/​7-slash-commands.md Removes the obsolete lesson.
docs/​ko-kr/​real-world-development/​cli/​7-qa-agent.md Adds the QA-agent lesson.
docs/​ko-kr/​real-world-development/​cli/​8-create-pull-request.md Adds Agent Merge guidance.
docs/​ko-kr/​real-world-development/​cli/​8-foundry-agent/​README.md Updates the final-review link.
docs/​ko-kr/​real-world-development/​cli/​8-foundry-agent/​2-build-and-deploy.md Clarifies the Codespace handoff.
docs/​ko-kr/​real-world-development/​cli/​8-foundry-agent/​3-connect-to-site.md Updates lesson references.
docs/​ko-kr/​real-world-development/​cli/​9-review.md Removes the obsolete review page.
docs/​ko-kr/​real-world-development/​cli/​9-cli-power-tools.md Adds the slash-command lesson.
docs/​ko-kr/​real-world-development/​cli/​10-review.md Adds the revised final review.
website/​astro.config.mjs Adds Korean sidebar translations.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/ko-kr/real-world-development/cli/README.md
Comment thread docs/ko-kr/real-world-development/cloud/3-custom-agents.md Outdated
Comment thread docs/ko-kr/real-world-development/cloud/2-cloud-agent.md
Comment thread docs/ko-kr/real-world-development/cloud/4-managing-agents.md Outdated
justinyoo and others added 2 commits October 13, 2026 20:33
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d99bfcc6-2569-40a3-a82a-b81a12e648c6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d99bfcc6-2569-40a3-a82a-b81a12e648c6

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread docs/ko-kr/real-world-development/cli/2-add-star-rating.md Outdated
Comment thread docs/ko-kr/real-world-development/cli/4-custom-instructions.md Outdated
Comment thread docs/ko-kr/real-world-development/cli/6-mcp-playwright.md Outdated
Comment thread docs/ko-kr/real-world-development/cloud/0-prerequisites.md Outdated
Comment thread docs/ko-kr/real-world-development/cloud/3-custom-agents.md Outdated
Comment thread docs/ko-kr/real-world-development/vscode/2-agent-mode.md Outdated
Comment thread docs/ko-kr/real-world-development/cloud/3-custom-agents.md Outdated
Comment thread docs/ko-kr/real-world-development/cloud/4-managing-agents.md Outdated
Comment thread docs/ko-kr/real-world-development/vscode/4-custom-agents.md Outdated
Comment thread docs/ko-kr/real-world-development/vscode/5-managing-agents.md Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d99bfcc6-2569-40a3-a82a-b81a12e648c6

@jamesmontemagno jamesmontemagno left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it deleted files... can you double check?

@jamesmontemagno
jamesmontemagno merged commit bb048c5 into github-samples:main Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants