Address v3.4.1 release review feedback - #254
Closed
taarikashenafi wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bad6e4b-711c-4c01-9354-2e4a9890efe1
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies the minimum scanner version for NPM plugins and documents the pinned Ruby action version.
Changes:
- Highlights scanner v3.4.1 as the minimum for NPM plugin loading.
- Annotates the pinned
ruby/setup-rubySHA with its matching release.
Show a summary per file
| File | Description |
|---|---|
PLUGINS.md |
Promotes the minimum-version requirement. |
.github/actions/find/README.md |
Adds the requirement to scans documentation. |
.github/workflows/test.yml |
Documents the pinned action version. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
Author
|
Closing because the release follow-up was handled directly on the original release PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the documentation and action-pin feedback from the v3.4.1 release PR (#253):
ruby/setup-rubySHA with its release version