Contributors table: keep every row at seven cells - #2938
Open
GuoCheng24 wants to merge 1 commit into
Open
Conversation
The last row carries eight <td> elements while all fifty-three others carry
seven. Each cell is fixed at width="14.28%" (one seventh), so eight of them
overflow the table: the final avatar renders narrower than the rest and sits
past the edge, reachable only by scrolling horizontally.
Moving that one cell onto its own row restores the invariant. Verified by
counting cells per row before and after: the distribution goes from {7, 8} to
{7, 1}, the 1 being the new trailing row that the next contributor fills.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The all-contributors table has 54 rows. Fifty-three carry seven
<td>elements; the last carries eight.Every cell is
width="14.28%"— one seventh — so eight in a row sums past 100%. The result is that the final avatar renders visibly narrower than every other avatar on the page and is pushed beyond the table's edge, reachable only by scrolling the table horizontally.Counting cells per row, before and after:
The fix moves that one cell onto its own row, which is where the next contributor would go anyway. Two added lines, no cell contents touched.
I noticed it because the eighth cell is mine, but the same thing will happen to whoever is added next unless the row is closed.