Skip to content

Show full descriptions on resource detail pages - #5386

Merged
aaronpowell merged 1 commit into
github:mainfrom
kinaj:kinaj-marketplace-description-wrapping
Oct 25, 2026
Merged

aaronpowell merged 1 commit into
github:mainfrom
kinaj:kinaj-marketplace-description-wrapping

Conversation

@kinaj

@kinaj kinaj commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services. (Not applicable: website-only change.)
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory. (Not applicable: no new resource.)
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot. (Not applicable: website change; browser checks are listed below.)
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description

An extension's detail page should show its full description. That is where users go to read the complete information, while catalog cards already cap descriptions at three lines. The detail page currently truncates descriptions even further, to two lines, including on mobile.

Remove the shared detail-page description clamp so descriptions wrap naturally without a line limit. Keep the existing two-line minimum for short descriptions and leave catalog cards unchanged. Because this is shared styling, the fix also applies to agents, instructions, skills, and plugins that use the same detail-page component.

Document this distinction in the website README.


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • New canvas extension.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify): Website description display fix.

Additional Notes

Before and after

Daily Focus Board at a narrow viewport, comparing an unchanged local copy with this branch:

Before: truncated after two lines After: full description
Daily Focus Board detail page with its description truncated after two lines Daily Focus Board detail page showing the complete description without truncation

Validation

  • npm start: passed; generated repository documentation is up to date.
  • npm run --prefix website build: passed; 1,549 pages built.
  • SITE_BASE_URL=http://127.0.0.1:4329 node website/scripts/reading-header-regression.mjs: passed all 12 light/dark route scenarios, including mobile layouts, reading-header handoff, and article-end confetti.
  • bash eng/fix-line-endings.sh: passed with a temporary BSD-sed compatibility wrapper on macOS.
  • git --no-pager diff --check: passed.
  • Additional browser assertions at 390px and 1440px: full Daily Focus Board description is visible; extension catalog descriptions retain their three-line limit.

The existing dev-server regression attempt timed out on stale Vite optimized dependencies. The browser regression passed against the production build instead. No CSP or scroll-progress behavior is changed by this PR.


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

Remove the shared two-line clamp while preserving the two-line minimum. Catalog descriptions remain capped at three lines.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:medium — New or substantially changed resource without privileged execution
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier
  • Changes files outside the low-risk documentation and resource paths

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s)
  • No staffed reviewer pool owns these files yet; any reviewer with write access counts as the domain reviewer.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for 1bef1a4 · gate run · This comment is maintained automatically — see submission gate docs.

@kinaj
kinaj marked this pull request as ready for review October 23, 2026 15:55
@kinaj
kinaj requested a review from a team as a code owner October 23, 2026 15:55
Copilot AI max review requested due to automatic review settings October 23, 2026 15:55
@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Oct 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The layout and reading-header measurements support variable description heights, catalog styling remains unchanged, and no blocking issues were identified.

No open issues 🎉

What changed in this PR

Shows full descriptions on resource detail pages through the shared detail-page component, while preserving compact catalog cards.

Changes:

  • Removes the two-line description limit while retaining the two-line minimum height.
  • Documents that detail descriptions display in full and catalog descriptions remain capped at three lines.
File Description
website/​src/​components/​brand/​styles/​dotnet-upgrade.module.css Removes description clamping and preserves minimum spacing.
website/​src/​components/​brand/​DetailChassis.tsx Uses the unclamped description style in shared detail pages.
website/​README.md Explains the detail-page and catalog display distinction.

Review effort: Max

@aaronpowell aaronpowell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kinaj — this is a clean fix. Removing heroDescriptionClamp from DetailChassis.tsx while keeping min-block-size: 2lh on .heroDescription gives full descriptions on detail pages without changing hero spacing for short ones, and catalog cards keep their three-line cap. Approving.

@aaronpowell
aaronpowell merged commit 352ebb3 into github:main Oct 25, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk:medium ready-for-review Submission passed intake validation and is ready for maintainer review website-update PR touches website content or code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants