Repository navigation
Show full descriptions on resource detail pages - #5386
Conversation
Remove the shared two-line clamp while preserving the two-line minimum. Catalog descriptions remain capped at three lines. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🚦 Submission status: 👀 Ready for reviewRisk tier: Why this tier
Automated checks
Review
Commands
Updated for |
There was a problem hiding this comment.
🟢 Approval recommended
The layout and reading-header measurements support variable description heights, catalog styling remains unchanged, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Shows full descriptions on resource detail pages through the shared detail-page component, while preserving compact catalog cards.
Changes:
- Removes the two-line description limit while retaining the two-line minimum height.
- Documents that detail descriptions display in full and catalog descriptions remain capped at three lines.
| File | Description |
|---|---|
| website/src/components/brand/styles/dotnet-upgrade.module.css | Removes description clamping and preserves minimum spacing. |
| website/src/components/brand/DetailChassis.tsx | Uses the unclamped description style in shared detail pages. |
| website/README.md | Explains the detail-page and catalog display distinction. |
Review effort: Max
aaronpowell
left a comment
There was a problem hiding this comment.
Thanks @kinaj — this is a clean fix. Removing heroDescriptionClamp from DetailChassis.tsx while keeping min-block-size: 2lh on .heroDescription gives full descriptions on detail pages without changing hero spacing for short ones, and catalog cards keep their three-line cap. Approving.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.mainbranch for this pull request.Description
An extension's detail page should show its full description. That is where users go to read the complete information, while catalog cards already cap descriptions at three lines. The detail page currently truncates descriptions even further, to two lines, including on mobile.
Remove the shared detail-page description clamp so descriptions wrap naturally without a line limit. Keep the existing two-line minimum for short descriptions and leave catalog cards unchanged. Because this is shared styling, the fix also applies to agents, instructions, skills, and plugins that use the same detail-page component.
Document this distinction in the website README.
Type of Contribution
Additional Notes
Before and after
Daily Focus Board at a narrow viewport, comparing an unchanged local copy with this branch:
Validation
npm start: passed; generated repository documentation is up to date.npm run --prefix website build: passed; 1,549 pages built.SITE_BASE_URL=http://127.0.0.1:4329 node website/scripts/reading-header-regression.mjs: passed all 12 light/dark route scenarios, including mobile layouts, reading-header handoff, and article-end confetti.bash eng/fix-line-endings.sh: passed with a temporary BSD-sed compatibility wrapper on macOS.git --no-pager diff --check: passed.The existing dev-server regression attempt timed out on stale Vite optimized dependencies. The browser regression passed against the production build instead. No CSP or scroll-progress behavior is changed by this PR.
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.