Patches from Debian package - #370
Open
keith-packard wants to merge 5 commits into
Open
keith-packard wants to merge 5 commits into
keith-packard wants to merge 5 commits into
Conversation
These are needed to actually use the library it seems. Signed-off-by: Keith Packard <keithp@keithp.com>
These options were documented in --help but missing from the man page. Signed-off-by: Keith Packard <keithp@keithp.com>
Some hardware is really slow; let users set CMARK_TIMING_SCALE to multiply the timeouts by an arbitrary amount Signed-off-by: Keith Packard <keithp@keithp.com>
The regular expressions in normalize.py and pathological_tests.py are missing a lot of backslashes -- you need two in the source file to get one in the string. Signed-off-by: Keith Packard <keithp@keithp.com>
The test needs to check if the test description is a valid key in the allowed_failures dictionary instead of attempting to fetch from the dictionary as most of the descriptions are not present in the dictionary leading to a missing key error at runtime. Signed-off-by: Keith Packard <keithp@keithp.com>
keith-packard
force-pushed
the
for-upstream
branch
from
January 6, 2025 17:03
33d6993 to
f29ba48
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The installed headers omit config.h, and C timing-scale parsing is inconsistent with Python.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds Debian packaging improvements for headers, CLI documentation, timeout scaling, and test correctness.
Changes:
- Installs additional library headers and documents missing CLI options.
- Adds
CMARK_TIMING_SCALEsupport to slow-test timeouts. - Corrects Python regex escaping and allowed-failure handling.
| File | Description |
|---|---|
src/CMakeLists.txt |
Installs additional headers. |
man/man1/cmark-gfm.1 |
Documents four CLI options. |
api_test/main.c |
Scales C timing limits. |
test/pathological_tests.py |
Scales timeouts and fixes regex/failure handling. |
test/normalize.py |
Corrects regex string escaping. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+178
to
+180
| install(FILES ${HEADERS} | ||
| DESTINATION include/cmark-gfm | ||
| ) |
Comment on lines
+945
to
+950
| static int _timing_scale = 1; | ||
| # define SETUP_TIMING() \ | ||
| do { \ | ||
| char *scale = getenv("CMARK_TIMING_SCALE"); \ | ||
| if (scale) \ | ||
| _timing_scale = atoi(scale); \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a set of patches that I wrote as a part of packaging cmark-gfm for Debian.
CMARK_TIMING_SCALE=10for debian packaging to ensure that even hppa builds work.allowed_failuresincorrectly.