-
Notifications
You must be signed in to change notification settings - Fork 487
Add support for Linux Arm64 runners #4072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: "Linux Arm64" | ||
| description: "An end-to-end integration test running on a Linux Arm64 runner, checking that the native linux-arm64 CodeQL bundle is downloaded and can analyze interpreted and compiled code" | ||
| operatingSystems: | ||
| - os: ubuntu | ||
| runner-image: ubuntu-24.04-arm | ||
| # The native linux-arm64 CodeQL bundle is only available in recent CLI releases, so we restrict this | ||
| # check to `nightly-latest`, which is guaranteed to ship it. Older stable versions do not have an | ||
| # arm64 asset, and `prepare-test` would resolve an x64 bundle URL for them on this runner. | ||
| versions: | ||
| - nightly-latest | ||
| installGo: true | ||
| steps: | ||
| - uses: ./../action/init | ||
| with: | ||
| languages: javascript,python,go | ||
| tools: ${{ steps.prepare-test.outputs.tools-url }} | ||
| - name: Build Go code | ||
| run: go build main.go | ||
| - uses: ./../action/analyze | ||
| with: | ||
| skip-queries: true | ||
| upload-database: false | ||
| - name: Assert databases exist | ||
| run: | | ||
| cd "$RUNNER_TEMP/codeql_databases" | ||
| for lang in javascript python go; do | ||
| if [[ ! -d "$lang" ]]; then | ||
| echo "Did not find a database for $lang" | ||
| exit 1 | ||
| fi | ||
| done | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ import { ConfigurationError } from "./util"; | |
|
|
||
| const SUPPORTED_PLATFORMS = [ | ||
| ["linux", "x64"], | ||
| ["linux", "arm64"], | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a good idea, we should stub the OS and architecture in "wrapCliConfigurationError - supported platform" rather than just testing on the OS / architecture on which we happen to be running. |
||
| ["win32", "x64"], | ||
| ["darwin", "x64"], | ||
| ["darwin", "arm64"], | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should run the queries, to check the database can be finalized and that it works to some extent. I'm not too concerned about the additional run time, as long as this doesn't become the longest check.