Skip to content

Apply security updates for js-yaml and tar dependencies - #4114

Open
beer-sakthai wants to merge 7 commits into
github:mainfrom
beer-sakthai:main
Open

Apply security updates for js-yaml and tar dependencies#4114
beer-sakthai wants to merge 7 commits into
github:mainfrom
beer-sakthai:main

Conversation

@beer-sakthai

Copy link
Copy Markdown

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.
  • High risk: Changes are not fully under feature flags, have limited visibility and/or cannot be tested outside of production.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.
  • Third-party analyses - The changes affect the upload-sarif action.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.
  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Test repository - This change will be tested on a test repository before merging.
  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).
  • Other - Please provide details.
  • None - I am not validating these changes.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Feature flags - All new or changed code paths can be fully disabled with corresponding feature flags.
  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.
  • Development/testing only - This change cannot cause any failures in production.
  • Other - Please provide details.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.
  • Other - Please provide details.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.
  • Special considerations - This change should only be merged once certain preconditions are met. Please provide details of those or link to this PR from an internal issue.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

stepsecurity-app Bot and others added 5 commits August 13, 2026 09:18
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
…-remediation

[StepSecurity] Apply security best practices
Clears the two open advisories reported by `npm audit` against the
locked dependency tree. Both fixes land inside the existing semver
ranges, so only `package-lock.json` changes:

- js-yaml 4.3.0 -> 4.3.1 and 3.15.0 -> 3.15.1 (GHSA-5p4m-2wfm-xmqj,
  CVE-2026-59870, high): quadratic CPU consumption resolving `!!omap`.
  Reached via @microsoft/eslint-formatter-sarif and supertap.
- tar 7.5.20 -> 7.5.22 (GHSA-r292-9mhp-454m, moderate): uncontrolled
  recursion in mapHas/filesFilter allows an uncatchable stack-overflow
  DoS from a crafted long-path archive. Reached via
  @mapbox/node-pre-gyp.

All three are dev-only dependencies, so the bundled output in `lib/`
does not change and needs no rebuild. The root `js-yaml` direct
dependency stays pinned at 5.2.3 — the 5.x line was already patched in
5.2.1 and is unaffected, so it is deliberately left out of this diff to
keep the change security-scoped.

Verified locally: `npm ci`, `npm run build`, and `npm run lint` all
pass, and `npm audit` reports 0 vulnerabilities.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QVUWKDpMHifLWzEYPF4NKL
Bump js-yaml and tar to patched versions (dev-only transitives)
@beer-sakthai
beer-sakthai requested a review from a team as a code owner August 27, 2026 16:02
@beer-sakthai
beer-sakthai marked this pull request as draft August 27, 2026 16:02
@beer-sakthai
beer-sakthai marked this pull request as ready for review August 27, 2026 16:02
claude and others added 2 commits August 27, 2026 16:07
Nothing in the tree said this was a fork, why it exists, or how it relates to
the SakThai repos that sit alongside it. Add FORK.md recording the two
dev-only advisory bumps it carries (js-yaml GHSA-5p4m-2wfm-xmqj, tar
GHSA-r292-9mhp-454m), links to the sibling repos, and the point that matters
most: no workflow in those repos references this fork. They pin upstream
`github/codeql-action` by commit SHA, and repointing them here would defeat
the SHA-pinning Scorecard's Pinned-Dependencies check relies on.

The README gets a single blockquote line pointing at FORK.md, kept to one line
so syncing from upstream stays a trivial resolution. Everything else in
README.md is upstream's and is untouched.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DKk5SVtHLSPCwSDASJhfRL
…links-xjhan3

docs: add FORK.md explaining this fork and its related repositories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants