-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add java data extensions various #22034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
knewbury01
wants to merge
11
commits into
github:main
Choose a base branch
from
knewbury01:knewbury01/add-mad-misc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
56647d5
Add java data extensions for sql injection sinks, sources, and a tain…
knewbury01 55ede0a
Fix spark taint preserve model
knewbury01 90054f9
Update java/ql/lib/ext/com.google.cloud.bigquery.model.yml
knewbury01 1fe3835
Merge branch 'main' into knewbury01/add-mad-misc
owen-mc 5ef164f
Update java/ql/lib/ext/io.javalin.http.model.yml
knewbury01 d72fa0a
Address review comments - add extra io.javalin.http sources
knewbury01 d6f1e33
Add summary models in io.javalin.security and io.javalin.validation
knewbury01 7d7b95d
Add extra models suggested to io.javalin.http.model.yml
knewbury01 28ed2ed
Add stubs for added models
knewbury01 9e8a246
Add first attempt generate lib tests for new models
knewbury01 c12337c
Add extra imports to lib test.ql's
knewbury01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| category: majorAnalysis | ||
| --- | ||
| * Added sink model for `sql-injection` for: `com.google.cloud.bigquery` and `org.apache.commons.dbutils`. | ||
| * Added a source model for: `spark` and `io.javalin.http`. | ||
| * Added a taint summary model for: `spark`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| extensions: | ||
| - addsTo: | ||
| pack: codeql/java-all | ||
| extensible: sinkModel | ||
| data: | ||
| - ["com.google.cloud.bigquery", "QueryJobConfiguration", true, "newBuilder", "", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["com.google.cloud.bigquery", "QueryJobConfiguration", true, "of", "", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["com.google.cloud.bigquery", "QueryJobConfiguration$Builder", true, "setQuery", "", "", "Argument[0]", "sql-injection", "manual"] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| extensions: | ||
| - addsTo: | ||
| pack: codeql/java-all | ||
| extensible: sourceModel | ||
| data: | ||
| - ["io.javalin.http", "Context", true, "basicAuthCredentials", "", "", "ReturnValue", "remote", "manual"] | ||
|
knewbury01 marked this conversation as resolved.
|
||
| - ["io.javalin.http", "Context", true, "body", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "bodyAsBytes", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "bodyAsClass", "", "", "ReturnValue", "remote", "manual"] | ||
|
knewbury01 marked this conversation as resolved.
|
||
| - ["io.javalin.http", "Context", true, "bodyInputStream", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "bodyStreamAsClass", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "cookie", "(String)", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "cookieMap", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "header", "(String)", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "headerMap", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "formParam", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "formParams", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "formParamMap", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "formParamAsClass", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "formParamsAsClass", "", "", "ReturnValue", "remote", "manual"] | ||
|
knewbury01 marked this conversation as resolved.
|
||
| - ["io.javalin.http", "Context", true, "pathParam", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "pathParamAsClass", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "pathParamMap", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "queryParam", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "queryParams", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "queryParamAsClass", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "queryParamsAsClass", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "queryParamMap", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "queryString", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "uploadedFile", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "uploadedFiles", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "uploadedFileMap", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "url", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "fullUrl", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "contentType", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["io.javalin.http", "Context", true, "userAgent", "", "", "ReturnValue", "remote", "manual"] | ||
| - addsTo: | ||
| pack: codeql/java-all | ||
| extensible: summaryModel | ||
| data: | ||
| - ["io.javalin.http", "UploadedFile", True, "content", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] | ||
| - ["io.javalin.http", "UploadedFile", True, "contentType", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] | ||
| - ["io.javalin.http", "UploadedFile", True, "extension", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] | ||
| - ["io.javalin.http", "UploadedFile", True, "filename", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| extensions: | ||
| - addsTo: | ||
| pack: codeql/java-all | ||
| extensible: summaryModel | ||
| data: | ||
| - ["io.javalin.security", "BasicAuthCredentials", True, "getPassword", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] | ||
| - ["io.javalin.security", "BasicAuthCredentials", True, "getUsername", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| extensions: | ||
| - addsTo: | ||
| pack: codeql/java-all | ||
| extensible: summaryModel | ||
| data: | ||
| - ["io.javalin.validation", "Validator", True, "get", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] | ||
| - ["io.javalin.validation", "Validator", True, "getOrDefault", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] | ||
| - ["io.javalin.validation", "Validator", True, "getOrNull", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] | ||
| - ["io.javalin.validation", "Validator", True, "getOrThrow", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| extensions: | ||
| - addsTo: | ||
| pack: codeql/java-all | ||
| extensible: sinkModel | ||
| data: | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "insert", "(Connection,String,ResultSetHandler)", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "insert", "(Connection,String,ResultSetHandler,Object[])", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "insert", "(String,ResultSetHandler)", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "insert", "(String,ResultSetHandler,Object[])", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "query", "(Connection,String,ResultSetHandler)", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "query", "(Connection,String,ResultSetHandler,Object[])", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "query", "(String,ResultSetHandler)", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "query", "(String,ResultSetHandler,Object[])", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "update", "(Connection,String)", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "update", "(Connection,String,Object[])", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "update", "(Connection,String,Object)", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "update", "(String)", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "update", "(String,Object[])", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "AsyncQueryRunner", true, "update", "(String,Object)", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "insert", "(Connection,String,ResultSetHandler)", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "insert", "(Connection,String,ResultSetHandler,Object[])", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "insert", "(String,ResultSetHandler)", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "insert", "(String,ResultSetHandler,Object[])", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "query", "(Connection,String,ResultSetHandler)", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "query", "(Connection,String,ResultSetHandler,Object[])", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "query", "(String,ResultSetHandler)", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "query", "(String,ResultSetHandler,Object[])", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "update", "(Connection,String)", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "update", "(Connection,String,Object[])", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "update", "(Connection,String,Object)", "", "Argument[1]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "update", "(String)", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "update", "(String,Object[])", "", "Argument[0]", "sql-injection", "manual"] | ||
| - ["org.apache.commons.dbutils", "QueryRunner", true, "update", "(String,Object)", "", "Argument[0]", "sql-injection", "manual"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| extensions: | ||
| - addsTo: | ||
| pack: codeql/java-all | ||
| extensible: sourceModel | ||
| data: | ||
| - ["spark", "Request", true, "body", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "bodyAsBytes", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "cookie", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "cookies", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "headers", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "params", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "queryMap", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "queryParams", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "queryParamsSafe", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "queryParamOrDefault", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "queryParamsValues", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "queryString", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "uri", "", "", "ReturnValue", "remote", "manual"] | ||
| - ["spark", "Request", true, "url", "", "", "ReturnValue", "remote", "manual"] | ||
| - addsTo: | ||
| pack: codeql/java-all | ||
| extensible: summaryModel | ||
| data: | ||
| - ["spark", "QueryParamsMap", True, "get", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] | ||
| - ["spark", "QueryParamsMap", True, "toMap", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] | ||
| - ["spark", "QueryParamsMap", True, "value", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] | ||
| - ["spark", "QueryParamsMap", True, "values", "", "", "Argument[this]", "ReturnValue", "taint", "manual"] |
80 changes: 80 additions & 0 deletions
80
java/ql/test/library-tests/frameworks/apache-commons-dbutils/Test.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| package generatedtest; | ||
|
|
||
| import java.sql.Connection; | ||
| import org.apache.commons.dbutils.AsyncQueryRunner; | ||
| import org.apache.commons.dbutils.QueryRunner; | ||
| import org.apache.commons.dbutils.ResultSetHandler; | ||
|
|
||
| public class Test { | ||
| Object source() { return null; } | ||
|
|
||
| public void testQueryRunnerSinks( | ||
| QueryRunner runner, Connection connection, ResultSetHandler<Object> handler) | ||
| throws Exception { | ||
| // "org.apache.commons.dbutils;QueryRunner;true;insert;(Connection,String,ResultSetHandler);;Argument[1];sql-injection;manual" | ||
| runner.insert(connection, (String) source(), handler); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;QueryRunner;true;insert;(Connection,String,ResultSetHandler,Object[]);;Argument[1];sql-injection;manual" | ||
| runner.insert(connection, (String) source(), handler, (Object[]) null); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;QueryRunner;true;insert;(String,ResultSetHandler);;Argument[0];sql-injection;manual" | ||
| runner.insert((String) source(), handler); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;QueryRunner;true;insert;(String,ResultSetHandler,Object[]);;Argument[0];sql-injection;manual" | ||
| runner.insert((String) source(), handler, (Object[]) null); // $ hasValueFlow | ||
|
|
||
| // "org.apache.commons.dbutils;QueryRunner;true;query;(Connection,String,ResultSetHandler);;Argument[1];sql-injection;manual" | ||
| runner.query(connection, (String) source(), handler); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;QueryRunner;true;query;(Connection,String,ResultSetHandler,Object[]);;Argument[1];sql-injection;manual" | ||
| runner.query(connection, (String) source(), handler, (Object[]) null); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;QueryRunner;true;query;(String,ResultSetHandler);;Argument[0];sql-injection;manual" | ||
| runner.query((String) source(), handler); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;QueryRunner;true;query;(String,ResultSetHandler,Object[]);;Argument[0];sql-injection;manual" | ||
| runner.query((String) source(), handler, (Object[]) null); // $ hasValueFlow | ||
|
|
||
| // "org.apache.commons.dbutils;QueryRunner;true;update;(Connection,String);;Argument[1];sql-injection;manual" | ||
| runner.update(connection, (String) source()); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;QueryRunner;true;update;(Connection,String,Object[]);;Argument[1];sql-injection;manual" | ||
| runner.update(connection, (String) source(), (Object[]) null); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;QueryRunner;true;update;(Connection,String,Object);;Argument[1];sql-injection;manual" | ||
| runner.update(connection, (String) source(), (Object) null); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;QueryRunner;true;update;(String);;Argument[0];sql-injection;manual" | ||
| runner.update((String) source()); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;QueryRunner;true;update;(String,Object[]);;Argument[0];sql-injection;manual" | ||
| runner.update((String) source(), (Object[]) null); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;QueryRunner;true;update;(String,Object);;Argument[0];sql-injection;manual" | ||
| runner.update((String) source(), (Object) null); // $ hasValueFlow | ||
| } | ||
|
|
||
| public void testAsyncQueryRunnerSinks( | ||
| AsyncQueryRunner runner, Connection connection, ResultSetHandler<Object> handler) | ||
| throws Exception { | ||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;insert;(Connection,String,ResultSetHandler);;Argument[1];sql-injection;manual" | ||
| runner.insert(connection, (String) source(), handler); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;insert;(Connection,String,ResultSetHandler,Object[]);;Argument[1];sql-injection;manual" | ||
| runner.insert(connection, (String) source(), handler, (Object[]) null); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;insert;(String,ResultSetHandler);;Argument[0];sql-injection;manual" | ||
| runner.insert((String) source(), handler); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;insert;(String,ResultSetHandler,Object[]);;Argument[0];sql-injection;manual" | ||
| runner.insert((String) source(), handler, (Object[]) null); // $ hasValueFlow | ||
|
|
||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;query;(Connection,String,ResultSetHandler);;Argument[1];sql-injection;manual" | ||
| runner.query(connection, (String) source(), handler); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;query;(Connection,String,ResultSetHandler,Object[]);;Argument[1];sql-injection;manual" | ||
| runner.query(connection, (String) source(), handler, (Object[]) null); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;query;(String,ResultSetHandler);;Argument[0];sql-injection;manual" | ||
| runner.query((String) source(), handler); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;query;(String,ResultSetHandler,Object[]);;Argument[0];sql-injection;manual" | ||
| runner.query((String) source(), handler, (Object[]) null); // $ hasValueFlow | ||
|
|
||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;update;(Connection,String);;Argument[1];sql-injection;manual" | ||
| runner.update(connection, (String) source()); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;update;(Connection,String,Object[]);;Argument[1];sql-injection;manual" | ||
| runner.update(connection, (String) source(), (Object[]) null); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;update;(Connection,String,Object);;Argument[1];sql-injection;manual" | ||
| runner.update(connection, (String) source(), (Object) null); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;update;(String);;Argument[0];sql-injection;manual" | ||
| runner.update((String) source()); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;update;(String,Object[]);;Argument[0];sql-injection;manual" | ||
| runner.update((String) source(), (Object[]) null); // $ hasValueFlow | ||
| // "org.apache.commons.dbutils;AsyncQueryRunner;true;update;(String,Object);;Argument[0];sql-injection;manual" | ||
| runner.update((String) source(), (Object) null); // $ hasValueFlow | ||
| } | ||
| } |
1 change: 1 addition & 0 deletions
1
java/ql/test/library-tests/frameworks/apache-commons-dbutils/options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| //semmle-extractor-options: --javac-args -cp ${testdir}/../../../stubs/apache-commons-dbutils |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.