Repository navigation
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| final F::Identifier getMacroNameNode() { unified_macro_call_expr_def(this, result) } | ||
|
|
||
| /** Gets the node corresponding to the field `type_argument`. */ | ||
| final F::Expr getTypeArgument(int i) { unified_macro_call_expr_type_argument(this, i, result) } |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The mapping drops Swift module qualifiers and incorrectly classifies compiler-provided expressions as macro calls.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds Swift freestanding macro expansion support to the Unified AST.
Changes:
- Introduces
macro_call_exprand generated QL/schema APIs. - Translates macro names, type arguments, arguments, and trailing closures.
- Adds Swift corpus coverage and updates
#lineextraction.
| File | Description |
|---|---|
unified/extractor/ast_types.yml |
Defines the macro-call AST shape. |
unified/extractor/src/languages/swift/swift.rs |
Maps Swift macro expansions. |
unified/extractor/tests/corpus/swift/expressions/freestanding-macro-expansions.swift |
Adds macro syntax fixtures. |
unified/extractor/tests/corpus/swift/expressions/freestanding-macro-expansions.output |
Records expected macro ASTs. |
unified/extractor/tests/corpus/swift/literals/line-magic-literal.output |
Reclassifies #line. |
unified/ql/lib/unified.dbscheme |
Adds generated database relations. |
unified/ql/lib/codeql/unified/internal/Ast.qll |
Adds generated QL classes and accessors. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| (argument name_node: (identifier #{label}) value: {closure}) | ||
| ), | ||
| rule!( | ||
| (macroExpansionExpr |
Contributor
Author
There was a problem hiding this comment.
I think handling these as macro calls might be just fine. And if not we can always tweak later.
Comment on lines
+724
to
+725
| macroName: @@name | ||
| genericArgumentClause: (genericArgumentClause arguments: (genericArgument argument: @type_args)*)? |
Contributor
Author
There was a problem hiding this comment.
We're not handling moduleSelector anywhere yet, so this is consistent.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new macro call expr to the AST and translates Swift's freestanding macro calls into it.
In Swift the arguments to a function are guaranteed to be valid Swift syntax, so we simply process all the arguments recursively and includes the result as arguments to the macro.