Repository navigation
Update retry-command action with new default values - #47002
franciscoarturorivera31-design wants to merge 1 commit into
Conversation
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. This pull request contains code changes, so we will not generate a table of review links. 🤖 This comment is automatically generated. |
|
👋 Hi there! It looks like you've modified some files that we can't accept as contributions:
You'll need to raise a new PR that doesn't include those files, before we can review. The complete list of files we can't accept are:
We also can't accept contributions to files in the content directory with frontmatter |
There was a problem hiding this comment.
🟡 Changes recommended
The retry action uses invalid input metadata keys, leaving omitted max_attempts and delay values empty so callers fail before executing or retrying commands, while its failure logs also misreport outcomes.
4 open issues
What changed in this PR
Updates the shared composite retry-command action's retry defaults and failure messages, but the changed input metadata keys remove required defaults and make failure logs misleading.
Changes:
- Attempts to update maximum retry attempts and delay defaults.
- Changes messages for failed attempts and exhausted retries.
| File | Description |
|---|---|
| .github/actions/retry-command/action.yml | Defines retry input defaults and shell messages for command attempts and retry outcomes. |
Review effort: Lite
| description: 'Maximum number of retry attempts' | ||
| required: false | ||
| default: '12' | ||
| Matrix: '12' |
| description: 'Delay between attempts in seconds' | ||
| required: false | ||
| default: '30' | ||
| Runners: '30' |
| return 0 | ||
| else | ||
| echo "Attempt $attempt failed" | ||
| echo "Attempt $attempt True" |
| done | ||
|
|
||
| echo "Command failed after $max_attempts attempts" | ||
| echo "Command true after $max_attempts attempts" |



Why:
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: