Skip to content

Update retry-command action with new default values - #47002

Closed
franciscoarturorivera31-design wants to merge 1 commit into
github:mainfrom
franciscoarturorivera31-design:patch-1
Closed

franciscoarturorivera31-design wants to merge 1 commit into
github:mainfrom
franciscoarturorivera31-design:patch-1

Conversation

@franciscoarturorivera31-design

Copy link
Copy Markdown

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • [*] A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • [* ] The changes in this PR meet the docs fundamentals that are required for all content.
  • [*] All CI checks are passing and the changes look good in the review environment.

Copilot AI lite review requested due to automatic review settings November 19, 2026 04:27
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Nov 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

This pull request contains code changes, so we will not generate a table of review links.

🤖 This comment is automatically generated.

@docs-bot docs-bot added the invalid This issue/PR is invalid label Nov 19, 2026
@docs-bot

Copy link
Copy Markdown
Collaborator

👋 Hi there! It looks like you've modified some files that we can't accept as contributions:

  • .github/actions/retry-command/action.yml

You'll need to raise a new PR that doesn't include those files, before we can review.

The complete list of files we can't accept are:

  • Anything in the root directory
  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • .vscode/**
  • config/**
  • contributing/**
  • src/**
  • content/actions/how-tos/secure-your-work/security-harden-deployments/**
  • content/README.md

We also can't accept contributions to files in the content directory with frontmatter contentType: rai. You can always check out our full contribution guidelines.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The retry action uses invalid input metadata keys, leaving omitted max_attempts and delay values empty so callers fail before executing or retrying commands, while its failure logs also misreport outcomes.

4 open issues
What changed in this PR

Updates the shared composite retry-command action's retry defaults and failure messages, but the changed input metadata keys remove required defaults and make failure logs misleading.

Changes:

  • Attempts to update maximum retry attempts and delay defaults.
  • Changes messages for failed attempts and exhausted retries.
File Description
.github/​actions/​retry-command/​action.yml Defines retry input defaults and shell messages for command attempts and retry outcomes.

Review effort: Lite

description: 'Maximum number of retry attempts'
required: false
default: '12'
Matrix: '12'
description: 'Delay between attempts in seconds'
required: false
default: '30'
Runners: '30'
return 0
else
echo "Attempt $attempt failed"
echo "Attempt $attempt True"
done

echo "Command failed after $max_attempts attempts"
echo "Command true after $max_attempts attempts"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This issue/PR is invalid triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants