[log] Add debug logging to copilot permissions, gh-aw-ref resolution, and add command - #56241
Merged
pelikhan merged 2 commits intoAug 27, 2026
Merged
Conversation
…dd command Instruments three pkg/cli files that had no or unused pkg/logger wiring: copilot-requests permission injection outcomes, --gh-aw-ref resolution, and the add command's top-level entry/failure points.
pelikhan
deleted the
add-debug-logging-cli-add-commands-7d681d9273f76b3d
branch
August 27, 2026 06:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds debug logging instrumentation (via
pkg/logger) to three CLI files involved in thegh aw addcommand: the top-level add command, Copilot permission injection, and--gh-aw-refresolution. It also fixes a minor code smell where themodifiedreturn value fromapplyFrontmatterLineTransformwas previously discarded.Change Classification
Key Changes
copilotPermissionsLoglogger; logs injection failure and success (withmodifiedflag); now captures previously-discardedmodifiedvalueaddGhAwRefLoglogger; logs ref resolution start, failure, and resolved SHAImpact Assessment
DEBUG-gated log output (namespacescli:add_copilot_permissions,cli:add_gh_aw_ref) and do not alter control flow, error behavior, or public APIs.gh aw addfailures related to Copilot permission injection and--gh-aw-refresolution.Commits