Repository navigation
Remove the conflicting -l shorthand from project new - #74561
Conversation
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
-l shorthand from project new
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
Comment MemoryPeek at saved memory (pr-code-quality-reviewer)Note This comment is managed by comment memory.Expand the saved memory block to view or edit the persistent context for this thread.
|
There was a problem hiding this comment.
Review complete: the flag removal introduces a compatibility break without resolving an intra-command collision.
Highlights
--logical-repoand--linkare on different commands, so the claimed collision does not occur withinproject new.- Existing
project new -l ...invocations now fail; retain the shorthand or document a deliberate breaking change and migration path.
🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~2 AIC · ⌖ ~1 AIC · ⊞ 1.6K
Comment /review to run again
|
|
||
| cmd.Flags().String("owner", "", "Project owner: '@me' for current user or organization name (required)") | ||
| cmd.Flags().StringP("link", "l", "", "Repository to link project to (format: owner/repo)") | ||
| cmd.Flags().String("link", "", "Repository to link project to (format: owner/repo)") |
There was a problem hiding this comment.
Removing -l breaks existing scripts without resolving an actual flag collision: --logical-repo belongs to the separate trial command, so users of gh aw project new ... -l owner/repo now get an unknown-flag error for no intra-command conflict.
💡 Preserve compatibility or document the intentional breaking change
Either retain the existing shorthand for project new, or provide a clear deprecation/migration path and release documentation if removing it is required. The current test only codifies removal and does not protect the user-facing compatibility decision.
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /tdd and /codebase-design. The change is correct and tight: it matches the existing --owner precedent (no shorthand), the test now asserts the new behaviour, and go test -run TestNewProjectNewCommand|TestProjectConfig passes. No stale -l references remain in code or docs.
One open question, left as an inline comment: whether the removed short form is a breaking change requiring a changeset depends on whether project new has already shipped, which I could not verify from this checkout.
📋 Review notes
pr-triagewas not invoked. The diff is 2 files and 4 changed lines, so skill selection used the fallback heuristic.- Inline comments: 1.
@copilot please address the review comment above.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · routed: haiku55 xhigh · ~2 AIC · ⌖ ~1 AIC · ⊞ 5.4K
Comment /matt to run again
|
|
||
| cmd.Flags().String("owner", "", "Project owner: '@me' for current user or organization name (required)") | ||
| cmd.Flags().StringP("link", "l", "", "Repository to link project to (format: owner/repo)") | ||
| cmd.Flags().String("link", "", "Repository to link project to (format: owner/repo)") |
There was a problem hiding this comment.
[breaking-change policy] Removing the -l short form is a flag short-form change, which .github/skills/developer-release/SKILL.md (Breaking CLI Rules) classifies as breaking and says needs a changeset. I could not confirm whether project new has shipped: it has no CHANGELOG entry, and no pending .changeset/*.md covers it. If the command has been released, add a changeset with the bump the rules require. If it has not, no changeset is needed, and the PR description should say the command is unreleased. @copilot please address this.
There was a problem hiding this comment.
🟡 Changes recommended
The CLI shorthand removal leaves the generated CLI documentation stale, still advertising the invalid -l option and requiring documentation updates.
1 open issue
What changed in this PR
This pull request removes the conflicting -l shorthand from gh aw project new --link, keeping -l available for --logical-repo.
Changes:
- Registers
--linkas a long-form-only option. - Updates tests to verify that
--linkhas no shorthand. - The CLI documentation still references
--link/-land should be updated.
This pull request is ready to be approved.
| File | Description |
|---|---|
pkg/cli/project_command.go |
Removes the conflicting -l shorthand from --link. |
pkg/cli/project_command_test.go |
Verifies that --link does not define a shorthand. |
Review effort: Lite (auto)
|
|
||
| cmd.Flags().String("owner", "", "Project owner: '@me' for current user or organization name (required)") | ||
| cmd.Flags().StringP("link", "l", "", "Repository to link project to (format: owner/repo)") | ||
| cmd.Flags().String("link", "", "Repository to link project to (format: owner/repo)") |
|
Note The pull request was not created — a fallback review issue was created instead due to protected file changes: #74656 PR FinisherSubmitted for publication (staged, not confirmed pushed): merge of Hand-off:
PR finisher dispatch requested for the following outstanding work: items 1-4 (merge main, Sous-chef head: 9615709
|
|
🎉 This pull request is included in a new release. Release: |

-lwas used for both--logical-repoandproject new --link, making the shorthand inconsistent across the CLI.--linkas a long option and remove its-lshorthand.gh aw project new "Bugs" --owner myorg --link myorg/myrepo