Repository navigation
Move three Terra-pinned workflows to economy model routing - #74660
SivaKesava1 merged 2 commits into
Conversation
Co-authored-by: SivaKesava1 <11771739+SivaKesava1@users.noreply.github.com>
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
Comment MemoryPeek at saved memory (pr-code-quality-reviewer)Note This comment is managed by comment memory.Expand the saved memory block to view or edit the persistent context for this thread.
|
There was a problem hiding this comment.
Review complete. One actionable compatibility risk was found in the Purelock routing change; see the inline comment. The specialist pass completed, and speculative schema/test-evidence concerns were not reported.
🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~3 AIC · ⌖ ~1 AIC · ⊞ 1.6K
Comment /review to run again
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the migration of three workflows to economy routing.
No open issues 🎉
What changed in this PR
Moves three gh-aw workflows from the retiring GPT-5.6 Terra pin to cost-oriented economy routing, addressing #74642 while preserving their existing tasks and permissions.
Changes:
- Enables GitHub-backed economy routing for two Codex workflows and one pi workflow.
- Regenerates execution locks with router setup, pinned images, and runtime model metadata.
- Removes inherited Terra pins from threat detection while leaving prompts, sub-agents, triggers, and safe outputs unchanged.
| File | Description |
|---|---|
.github/workflows/refactoring-cadence.md |
Replaces the Terra pin with economy routing for pi. |
.github/workflows/refactoring-cadence.lock.yml |
Adds pi routing setup and propagates selected-model metadata. |
.github/workflows/purelock.md |
Enables Codex economy routing without changing sub-agents. |
.github/workflows/purelock.lock.yml |
Adds routing infrastructure and removes agent and detection Terra pins. |
.github/workflows/front-page-copy-guard.md |
Replaces the Terra pin with Codex economy routing. |
.github/workflows/front-page-copy-guard.lock.yml |
Adds routing setup, metadata reporting, and default detection-model selection. |
Review effort: Balanced (auto)
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /diagnosing-bugs to the routing change. Requesting changes because the economy router can still select the model this PR is meant to retire.
📋 Key Themes & Highlights
Key Themes
- Terra still selectable:
model-routingwithcandidate-modelsdefaulting to thegpt-*family (github-copilot/gpt-*in the compiled config) expands to every GPT model in the catalogue, includinggpt-5.6-terra. None of the three workflows excludes it. Two (purelock, front-page-copy-guard) have no allowlist, and refactoring-cadence has none either. Routed smoke workflows already useallowed-modelsfor this. - Prompt-injection risk: The existing bot comment on
purelock.lock.yml(line 1290) flags the routing pre-step, which writes the rendered prompt as a single user-role message. Worth confirming whether that risk is accepted. - Compile warning:
test-writersub-agent is configured with thelargemodel, which may be incompatible with the codex routing API. The author notes this as a follow-up.
Positive Highlights
- ✅ Clean, minimal frontmatter change; the removed
model:pins are the right direction. - ✅ Committed lock files reproduce from the
HEADsources, apart from scheduled cron comment lines. - ✅
refactoring-cadencemigration to the map form forengineis correct for pi.
Scope note: the local checkout is stale, so I reviewed committed HEAD and built gh-aw to recompile. I did not run the workflows, and I did not verify runtime ranking of Terra against Luna and Sol.
@copilot please address the inline comments above.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · routed: haiku55 xhigh · ~8 AIC · ⌖ ~1 AIC · ⊞ 5.4K
Comment /matt to run again
|
Warning Threat detection engine error Threat detection could not complete its analysis due to a tooling error. This is not a security finding. What happenedThe threat detection engine failed to produce results. Review the workflow run logs to troubleshoot the error. Note The pull request was not created — a fallback review issue was created instead due to protected file changes: #74678 PR Finisher pass (submitted for publication, not confirmed pushed):
PR finisher dispatch requested for the following outstanding work: merge main, and the review items on purelock.lock.yml:1290, purelock.md:19, front-page-copy-guard.md:19 and refactoring-cadence.md:20. Sous-chef head: 59b4e94
|
|
Note The pull request was not created — a fallback review issue was created instead due to protected file changes: #74704 PR Finisher
CI is stale after push and needs a maintainer re-trigger. PR finisher dispatch requested for the following outstanding work (summary). Sous-chef head: 59b4e94
|
PR Finisher: no changes submitted
CI will need a maintainer re-trigger after the merge. Sous-chef head: 59b4e94
|
Addressed: Terra drops out of the live pool when it retires, and #74642 asks for no allowed-models list. test-writer was verified with routed run 41745095607 (all requests 200). Threads answered and resolved.
|
🎉 This pull request is included in a new release. Release: |
GPT-5.6 Terra is retired across Copilot on 16 November 2026. Purelock, Front Page Copy Guard and Refactoring Cadence each pin
copilot/gpt-5.6-terraand would stop working then. This PR moves them to cost-oriented model routing (economy) instead of pinning another model.Frontmatter
purelock.md,front-page-copy-guard.md: removemodel: copilot/gpt-5.6-terraand add routing to the existing Codex engine block:refactoring-cadence.md: replaceengine: piand the Terra pin with the same block, usingid: pi.copilot-requests: writewas already present on all three and is kept. Prompts, steps, sub-agents, triggers and safe outputs are unchanged, and no model allow or block lists are added.Lock-file changes (all three)
"routing":{"enabled":true,"goal":"cost","mode":"economy",…}.gh-aw-firewall/router:0.29.6@sha256:fce2f3be….COPILOT_GITHUB_TOKEN: ${{ github.token }}.COPILOT_MODEL), so detection uses its default model.GH_AW_MODEL_ROUTING*env.Notes for reviewers
sub-agent "test-writer" model "large" may be incompatible with the codex engine's model-routing API. The issue asks to keep sub-agents unchanged, so this PR leaves it for a follow-up.make agent-finishstops atgolint: it flags three style findings in existingpkg/cli/update_*.gofiles that this PR doesn't touch. I didn't check whether this also fails onmain.windows.md,cloclo.mdandsmoke-copilot-sub-agents.md, which the issue lists separately.gh aw audit(the issue's "Check" section). The issue expects GPT-5.6 Luna picks, or Claude Haiku 5.5 for pi. Repeatedgpt-5.6-solpicks would mean switching to acopilot/gpt-6.1-solpin.