fix(oauth): advertise only default scopes in protected resource metadata - #3251
Merged
Merged
Conversation
Keep the full OAuth scope catalog available for per-tool step-up challenges, but limit protected resource discovery to the lower-risk default grant. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The regression test derives its expectation from production state and cannot detect accidental default-scope expansion.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
pkg/http/oauth/oauth_test.go — This expected value is the same package variable assigned to ScopesSupported, so an accidental… |
What changed in this PR
Limits initial OAuth grants to default scopes while preserving step-up challenges for optional permissions, addressing #3170.
Changes:
- Advertises
DefaultScopesin protected-resource metadata. - Expands scope regression assertions.
- Documents default and step-up scope behavior.
| File | Description |
|---|---|
pkg/http/oauth/oauth.go |
Uses default scopes in metadata. |
pkg/http/oauth/oauth_test.go |
Updates metadata and opt-in scope tests. |
docs/streamable-http.md |
Documents advertised default scopes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
SamMorrowDrums
deleted the
sammorrowdrums-debug-oauth-metadata-scopes
branch
September 8, 2026 18:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultScopesfrom OAuth protected resource metadata instead of the full step-up scope catalogdelete_repo,workflow, and administrative scopes available through per-tool authorization challengesRoot cause
#3076 split the OAuth catalog into supported and default scopes, but intentionally left protected resource metadata wired to
SupportedScopes. OAuth clients such as VS Code interpretscopes_supportedas the initial authorization request, so production requested every optional scope at login.Closes #3170