Repository navigation
Conversation
Read and validate the Electron target from nativeBuild while retaining support for older VS Code metadata formats. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0d6e4f27-75bf-4d77-8758-1ef757ddb3db
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the update supporting VS Code’s new Electron metadata format.
No open issues 🎉
What changed in this PR
Updates maintenance automation to read VS Code 1.147.0’s Electron version from nativeBuild metadata, allowing the scheduled Node version updater to support the new format.
Changes:
- Reads and validates
nativeBuild.targetwhen the runtime is Electron. - Preserves dependency-based and
.npmrclookup for older releases. - Adds regression tests for valid, missing, and invalid targets, plus non-Electron runtime fallback.
| File | Description |
|---|---|
extensions/ql-vscode/test/unit-tests/scripts/util/vscode-versions.test.ts |
Adds nativeBuild validation and fallback regression coverage. |
extensions/ql-vscode/scripts/util/vscode-versions.ts |
Supports Electron nativeBuild metadata while retaining older lookup formats. |
Review effort: Balanced (adaptive)
cklin
enabled auto-merge
November 19, 2026 19:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the scheduled Node version updater failing for VS Code 1.147.0, which stores its Electron version in
package.jsonundernativeBuild.targetrather thandevDependencies.electronor a root.npmrc.Read and validate
nativeBuild.targetwhennativeBuild.runtimeiselectron, while retaining the existing package dependency and.npmrcformats for older releases. Add regression coverage for the new format, missing or invalid targets, and non-Electron runtime fallback.Addresses the failure in https://github.com/github/vscode-codeql/actions/runs/44523521233.
Validation from
extensions/ql-vscode:npm run test:unit -- --runInBand --runTestsByPath test/unit-tests/scripts/util/vscode-versions.test.ts- passed (11 tests)../node_modules/.bin/eslint test/unit-tests/scripts/util/vscode-versions.test.ts --max-warnings=0- passed../node_modules/.bin/tsc --project scripts/tsconfig.json --noEmit- passed.No changelog entry is needed because this only changes maintenance automation.
Remember to update the changelog if there have been user-facing changes!