Repository navigation
fix(desktop): publish versioned GitHub releases with signed DMGs - #198
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #197. Related: #7.
Desktop publishing previously only uploaded the signed archive and Sparkle feed to R2. Add a GitHub release for each published channel/version, tagged at the manifest source revision with the signed DMG attached. Canary releases are published prereleases, never latest stable. Build-only runs remain unpublished.
Create a draft, verify the uploaded asset digest, then publish it before the Sparkle feed commit point. Retries resume drafts or reuse matching releases/assets, refusing conflicting tags or bytes. Grant the release job contents-write permission and supply its GitHub token to the publishing step. Document publishing, recovery, and GitHub-only backfilling.
Validation
bun types,bun run ci,git diff --checkpassed; workflow YAML parsed with Bun.Built in Ace
Entirely built in Ace using this channel, its isolated lane, shell tools, and a review subagent. Used the authenticated GitHub CLI through Ace for issue/PR operations and real release backfill/verification. No external editor, terminal, or agent.