Repository navigation
refactor: reduce complexity of execute_impl in src/safe_outputs/create_wiki_page.rs - #2412
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateWikiPageResult::execute_implwas flagged byclippy::too_many_lines(158/100). Clippy's cognitive_complexity lint flagged nothing, so I used line count as the metric.Extracted helpers, with no behaviour change:
resolve_effective_path: normalises the path and applies the traversal, path-prefix and title-prefix rules.push_version_descriptor: de-duplicates the branch query params used by the GET and PUT requests.check_page_absent: the GET existence check.put_new_page: the create-only PUT withIf-Match: "", plus the 412 and error mapping.created_page_result: builds the success result.Result:
execute_implis no longer flagged bytoo_many_lines.Validation:
cargo testpasses in full (35 create_wiki_page tests).cargo clippy --all-targets --all-featuresshows no warnings for this file.Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
releaseassets.githubusercontent.comspsprodeus21.vssps.visualstudio.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.