Repository navigation
Polish the living document flow - #457
Open
MaggieAppleton wants to merge 7 commits into
Open
MaggieAppleton wants to merge 7 commits into
MaggieAppleton wants to merge 7 commits into
Conversation
MaggieAppleton
force-pushed
the
living-design-review
branch
from
October 10, 2026 12:47
ccfb7db to
82c7553
Compare
MaggieAppleton
added this pull request to stack #455
October 10, 2026 12:49
MaggieAppleton
marked this pull request as ready for review
October 10, 2026 12:50
MaggieAppleton
force-pushed
the
living-design-review
branch
from
October 10, 2026 13:10
82c7553 to
d1c8f60
Compare
MaggieAppleton
force-pushed
the
living-design-review
branch
from
October 10, 2026 13:24
d1c8f60 to
5e338aa
Compare
MaggieAppleton
force-pushed
the
living-design-review
branch
from
October 10, 2026 13:55
5e338aa to
d513afb
Compare
MaggieAppleton
force-pushed
the
living-design-review
branch
from
October 10, 2026 15:05
d513afb to
ea9b16a
Compare
MaggieAppleton
force-pushed
the
living-design-review
branch
from
October 10, 2026 15:26
ea9b16a to
ee7e450
Compare
MaggieAppleton
force-pushed
the
living-design-review
branch
from
October 10, 2026 17:04
ee7e450 to
eacc7f4
Compare
MaggieAppleton
force-pushed
the
living-design-review
branch
from
October 10, 2026 17:32
eacc7f4 to
03c040a
Compare
MaggieAppleton
force-pushed
the
living-design-review
branch
from
October 10, 2026 18:34
caa1655 to
f204622
Compare
MaggieAppleton
force-pushed
the
living-design-review
branch
from
October 10, 2026 19:45
1832d89 to
33a12d0
Compare
MaggieAppleton
force-pushed
the
living-design-review
branch
from
October 10, 2026 20:11
33a12d0 to
3b0e15a
Compare
|
The preview deployment for chopin failed. 🔴 Open Build Logs | Open Application Logs Last updated at: 2026-10-10 20:16:32 CET |
MaggieAppleton
force-pushed
the
living-design-review
branch
3 times, most recently
from
October 10, 2026 21:38
e954b31 to
f544612
Compare
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Give the living document one sync vocabulary (In sync, Out of sync, Syncing…, Sync failed) with a tooltip for every state, and make the Build headline match it. Finished tasks show what they did instead of boilerplate acceptance criteria. Tasks added by later syncs get their own "Since first build" section, and an unbuilt Planner draft no longer adds duplicate rows. The header slot sits correctly on narrow layouts, a failed first build stays visible, and spike callouts lead with the recommendation in shorter copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ving document flow The header reads "Waiting on a decision" while a one-click build waits and opens Decisions, and "Needs attention" when an in-sync document still has blocked tasks. Syncs that needed no code change appear quietly under "Since first build". On narrow layouts the header slot keeps the page behind it so it no longer floats over scrolled text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
At narrow widths the build slot floated over the top of the document and covered scrolled prose. It now takes its own row above the document. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Hide the build slot while the view it opens is showing; the view's status line already says the same thing. - Use one glyph vocabulary: clock for waiting (queued, out of sync), the decision glyph for a pending decision, warning dot for attention; hollow rings stay task states only. - Keep the blocker out of the Needs attention status line (the blocked row shows it) and cap it in the tooltip; mark a task the first build left unfinished with the warning dot and open it. - Drop the elapsed timer from a queued build, write the blocked-task retry as one clause, give no-change rows a check and a first-line timestamp, and wrap long agent text instead of widening the page at 390px. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An unfinished task's row now gives the agent's last report, or where it stopped, and the headline names the task an edit retries. Blockers drop stacked "Blocked:" labels and show GitHub links as owner/repo#N, linked in the row. The warning dot shares the reason's warning family, wrapped tooltips read left-aligned, Decisions says when answering starts a waiting build, and the Build headline lines up with the task titles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaggieAppleton
force-pushed
the
living-design-review
branch
from
October 10, 2026 22:23
f544612 to
e045c7d
Compare
…running spike The header slot flashed "Syncing…" for the last seconds of a first build, after it delivered but before its agent exited; it now keeps "Building…" until the build ends. A one-click build drafted while a spike runs added a task that prototyped the same passage again; the Planner now leaves that to the spike and has the implementing task follow its result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A design pass over the living document flow (spikes → Build plan → first build → In sync / Out of sync), done on the real "Margin — living document", with route interception for the other states.
Top findings → what changed
live.tasks, so the real document went from 8 to 14 rows with duplicate keys. NowliveSnapshotlists only versions that ran (regression test added).✓ In sync · 2 commits since first build,○ Out of sync · Waiting for @x's agent).minmax(0, 1fr).Recommended but not in this PR: hide the header slot while Build is open; list a sync's commits under the task it added; a collapsible result callout; a cancel control on the callout instead of "Delete this callout to cancel"; a label other than "Building…" for a first build that is still queued.
Screenshots
Build view, live and in sync (1440): before / after


Build plan in the narrow layout (390): before / after


Out of sync in the narrow layout (390): before / after


Header slot: sync failed and syncing: before / after





Testing
bun run types,bun test(4551 pass with the untracked design jigs moved aside),bun run ci,bun run build. The initial chunk is unchanged at 80,590 B gzip; all new code is in the room chunk.syncLabel,syncTooltip,liveTaskGroupsand the hint copy inbuild-model.test.ts; spike callout copy and report order inspikes.test.ts; draft exclusion and sync-task acceptance inroutes.test.ts. The draft test fails without the fix.LIVE_BUILD=on LIVE_SPIKES=on), using route-intercepted snapshots for the out-of-sync, failed and syncing states at 1440 and 390px. Chopin has no dark theme, so there was nothing to check there.copilot --acp --allow-allon github.com/MaggieAppleton/margin: the first build of 8 tasks opened margin PRs Let the planner reach for a diagram or a formula #7 to #14, and the live edit "Snooze 15 -> 5" went Out of sync, then Syncing... (+44s), then In sync (+92s) as commit a1f2f553 on the existing PR Add type scale tokens, replace arbitrary font sizes #12. It is listed under "Since first build".Stack
Stacked on #454 (
living-spikes), the top of #450 → #451 → #452 → #453 → #454. This repository merges rebase-only: after a lower PR lands, rebase and push with--force-with-lease.🤖 Generated with Claude Code
Second pass
This pass reviewed the new states end to end: waiting on a decision, queued, needs attention, out of sync with blocked tasks, cancel build, and no-change syncs. The full critique is in
/tmp/living-design-review/critique-2.md. The after-screens were rendered on a local fake-GitHub server with intercepted snapshots.overflow-wrap: anywhere)“X” is blocked. Edit the document to retry.); the row shows the reason; the tooltip caps it at about 120 charactersNot changed (recommended): agent prose is long (it needs a server-side summary and details split); a stale task survives a no-change sync; spike callouts still say "Delete this callout to cancel".
Blocker at 390px
Needs attention at 1440px
Unfinished task
Queued
Waiting on a decision
Out of sync
No code change rows
Final pass
owner/repo#N, and the row links them.--color-warningfamily. Wrapped tooltips are left-aligned.Last pass
A real run on margin confirmed the spike lands before a queued build starts. Its result reached the first build, and no rebuild followed the callout. Two rough edges remained: