Repository navigation
Give the phone document header the project, build status and people here - #537
Merged
Merged
Conversation
Collaborator
Author
|
Review: Looks good Checked in headless Chromium on a built server, mobile emulation with touch, at 390×844 and 430×932. I compared against What works
Nits (non-blocking)
Open questions (my opinion)
CI: all 5 checks green (container, e2e, format/lint/types/tests, chopin CLI, chopin CLI Windows). |
The phone top bar now matches the desktop two-bar header's vocabulary: the title sits over a subtitle naming the project and the build (the capsule's glyph and label, or Build plan, as links), with up to two faces beside the actions. An open child takes the bar instead of adding a stack bar: Back on the left, the child's own title, people and actions, and "in <parent>" beneath it. The build's state keeps 12px or more from the faces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
workspace.tsx only stops drawing the stack bar on phones; the reviewed feedback and chatPresence class boundaries are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tion, and size phone faces to 20px Reduced motion drops the subtitle's slide. A child's subtitle reads "in <Root> · Editing" while editing rather than losing its parent. Faces are 20px, as in the jig; they are not controls, so they need no target of their own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the title truncates beside two faces, the bar shows one face and counts the rest before anything else gives way. It returns to two only once the title would still fit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Chat, Decisions and Build belong to the root, so off Document the bar is the root's again, with its Documents button, title, build status and actions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaggieAppleton
force-pushed
the
design-phone-doc-header
branch
from
October 13, 2026 11:16
13549f0 to
de8a972
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phones now get the Direction D document header (follow-up from #507): title over a
project · buildsubtitle, the people here, and a child view that takes the bar instead of stacking a second one.Root
score · <build>. The build part is the capsule's own glyph and label (Building · 2 of 5,● Built,⚠ Build failed · Retry,● 3 changes · Build) or Build plan, shown as links with invisible 44pt targets. Tapping opens Build, explains a block, or runs the action, same as the capsule did.Child (Zoom on phone)
Back to <Root>), the child's title,in <Root>, the child's people, comments and ⋯. Actions and rename act on the child: the child room portals its controls into the bar, as split Zoom does.Unchanged: bottom tab bar and badges, keyboard-docked formatting toolbar, hide-on-scroll bar, safe areas, translucent glass.
Before / after (390, light):
Decisions (Maggie, after review)
+1), and returns to two once the title fits again.Follow-ups from review: reduced motion drops the subtitle slide; a child that is being edited reads
in <Root> · Editing; faces are 20px as in the jig.Tests
phone-workspace.e2e.ts(390 and 430: subtitle centring, project/build/people, 44pt targets, long-title truncation, one-face fallback, build ≥12px from faces) andresponsive-child-phone.e2e.ts(child takes the bar on Document only, the root's bar on Chat and Decisions, child rename,in <Root> · Editing, Back returns).bun run ciandbun run typespass, and the web unit tests pass apart from ignored local jig files.workspace.tsx. The only change there isstackBarnow being false on phones; the reviewed class boundaries are unchanged.🤖 Generated with Claude Code
Landing validation
The landing rebase preserves all six author patches. The combined workspace candidate passed CI, types, production build, 20 focused units, 38 workspace browser cases, and all eight latest child-phone cases. The source-preserving refresh is landed with administrator bypass of a new full CI cycle; prior GitHub CI was green.