Pattern miner: Add protected-files tip to code-improvement and documentation-updater archetypes - #161
Merged
pelikhan merged 1 commit intoAug 26, 2026
Conversation
… archetypes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
marked this pull request as ready for review
August 26, 2026 06:11
pelikhan
deleted the
pattern-miner-protected-files-29432-ac304ede06ce5510
branch
August 26, 2026 06:11
Contributor
Author
There was a problem hiding this comment.
Reviewer kind: auto (no TS/JS or UI files changed — this PR only edits patterns/archetypes/*.json data files).
Reviewed the two-line tip additions to code-improvement.json and documentation-updater.json. Both are well-scoped, factually consistent with cited upstream evidence (protected-files: fallback-to-issue usage across 16 upstream workflows), and match the existing tips array style/format. No correctness, security, or structural JSON issues found. No blocking changes requested.
Generated by Specialist PR Review for #161 · auto · 11.6 AIC · ⌖ 2.39 AIC · ⊞ 7.9K
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was mined
Sources examined:
githubnext-agenticsworkflows (/tmp/gh-aw/data/upstream/githubnext-agentics/files/workflows/*.md), 55 filesgithub-gh-awdocs (/tmp/gh-aw/data/upstream/github-gh-aw/files/.github/aw/*.md), used only to confirm current gh-aw v0.87+ frontmatter supportRecurring pattern found
16 of the upstream
githubnext-agenticsworkflows that usecreate-pull-requestsafe outputs setprotected-files: fallback-to-issueexplicitly, rather than relying on the default (request_review/blocked):adhoc-qa.md,agentic-wiki-coder.md,ci-coach.md,code-simplifier.md,doc-updater.md,glossary-maintainer.md,link-checker.md,perf-improver.md,repo-assist.md,tech-content-editorial-board.md(viaif-no-changes),test-improver.md,unbloat-docs.md,update-docs.md, plus supporting docs ingithub-gh-aw/files/.github/aw/safe-outputs-content.mdandsafe-outputs-management.md, which documentprotected-filesas the primary guardrail forcreate-pull-request/push-to-pull-request-branchalongsideallowed-files.This is a genuinely recurring, cross-repo convention (13+ upstream workflows) plus explicit upstream documentation recommending it, satisfying the "at least two upstream workflows, or one plus explicit docs" bar.
Why the existing library did not cover it
patterns/archetypes/code-improvement.jsonandpatterns/archetypes/documentation-updater.json(the two curated/measured archetypes that recommendcreate-pull-request) already advise scoping changes and using DO NOT constraints, but neither mentioned theprotected-filessafe-output setting that prevents unreviewed PRs from touching manifests, CI configs, or agent instruction files. No other archetype tip or anti-pattern entry referencesprotected-files.What changed
patterns/archetypes/code-improvement.json: added one tip recommendingprotected-files: fallback-to-issueoncreate-pull-request.patterns/archetypes/documentation-updater.json: added the same tip, scoped to manifests/CI configs.No other fields (
success_rate,count,top_repos,anti_patterns,metadata,trigger_combos,research_findings) were touched.patterns/manifest.jsonandpatterns/workflow-generation.jsonwere left unchanged since this is a tips-only refinement, not a new archetype or a runtime-generation change.Validation
npm test: 187 passed (12 test files), no failures.npm run build: succeeded, produceddist/including updatedpatterns/archetypes/code-improvement.jsonanddocumentation-updater.json.Candidates deliberately left out
deployment_status/workflow_runincident-triage archetype: only 2 upstream workflows (ci-doctor.md,cost-tracker.md) useworkflow_run, and none usedeployment_statusdirectly (only referenced in docs).workflow_runis already flagged as high-risk (13% success) inresearch_findings/trigger_combos, so a new archetype built around it would contradict existing guidance rather than add value.duplicate-code-detector.md,large-file-simplifier.md) useassignees: copilotoncreate-issue, below the 2-workflow-plus-docs bar for a full archetype, and the underlying shape is already close tocode-health-auditor.link-checker.md); the shape (schedule + create-pull-request + docs scope) overlaps heavily withdocumentation-updater.