Skip to content

ci: use setup-vp for JavaScript tooling #3245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
setchy merged 2 commits into from
Sep 2, 2026
Merged

ci: use setup-vp for JavaScript tooling #3245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f0e617
ci: use setup-vp for JavaScript tooling
afonsojramos Sep 1, 2026
8b69f83
fix(ci): run JavaScript commands through Vite+
afonsojramos Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions .github/actions/setup-node/action.yml
View file
Open in desktop

This file was deleted.

14 changes: 8 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,17 @@ jobs:
include:
- os: macos-latest
platform: macOS
package-cmd: pnpm package:macos --publish=never -c.mac.identity=null
package-cmd: vp run package:macos -- --publish=never -c.mac.identity=null
cleanup-path: dist/mac-universal
artifact-name: Gitify-dist-mac
- os: windows-latest
platform: Windows
package-cmd: pnpm package:win --publish=never
package-cmd: vp run package:win -- --publish=never
cleanup-path: dist/win-unpacked
artifact-name: Gitify-dist-win
- os: ubuntu-latest
platform: Linux
package-cmd: pnpm package:linux --publish=never
package-cmd: vp run package:linux -- --publish=never
cleanup-path: dist/linux-unpacked
artifact-name: Gitify-dist-linux
runs-on: ${{ matrix.os }}
Expand All @@ -48,11 +48,13 @@ jobs:
with:
persist-credentials: false

- name: Setup Node.js
uses: ./.github/actions/setup-node
- name: Setup Vite+
uses: voidzero-dev/setup-vp@1b32467adbe183473499fd9d5d372c3ed9641754 # v1.18.0
with:
cache: true

- name: Build application
run: pnpm build
run: vp run build

- name: Package for ${{ matrix.platform }}
run: ${{ matrix.package-cmd }}
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@ jobs:
with:
persist-credentials: false

- name: Setup Node.js
uses: ./.github/actions/setup-node
- name: Setup Vite+
uses: voidzero-dev/setup-vp@1b32467adbe183473499fd9d5d372c3ed9641754 # v1.18.0
with:
cache: true

- name: Run lint and format checks
run: pnpm check
run: vp run check

lint-actions:
name: Lint GitHub Actions [actionlint]
Expand Down
14 changes: 8 additions & 6 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,17 @@ jobs:
include:
- os: macos-latest
platform: macOS
package-cmd: pnpm package:macos --publish onTagOrDraft
package-cmd: vp run package:macos -- --publish onTagOrDraft
artifact-name: Gitify-release-mac
use-apple-notarization: true
- os: windows-latest
platform: Windows
package-cmd: pnpm package:win --publish onTagOrDraft
package-cmd: vp run package:win -- --publish onTagOrDraft
artifact-name: Gitify-release-win
use-apple-notarization: false
- os: ubuntu-latest
platform: Linux
package-cmd: pnpm package:linux --publish onTagOrDraft
package-cmd: vp run package:linux -- --publish onTagOrDraft
artifact-name: Gitify-release-linux
use-apple-notarization: false
runs-on: ${{ matrix.os }}
Expand All @@ -66,11 +66,13 @@ jobs:
with:
persist-credentials: false

- name: Setup Node.js
uses: ./.github/actions/setup-node
- name: Setup Vite+
uses: voidzero-dev/setup-vp@1b32467adbe183473499fd9d5d372c3ed9641754 # v1.18.0
with:
cache: true

- name: Build application
run: pnpm build
run: vp run build
env:
OAUTH_CLIENT_ID: ${{ secrets.OAUTH_CLIENT_ID }}

Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/renovate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ jobs:
persist-credentials: false
sparse-checkout: |
renovate.json
package.json
pnpm-lock.yaml
.github

- uses: ./.github/actions/setup-node
- uses: voidzero-dev/setup-vp@1b32467adbe183473499fd9d5d372c3ed9641754 # v1.18.0
with:
cache: true
run-install: 'false'

- name: Install Renovate
run: pnpm install --global renovate

- name: Validate Renovate config
run: renovate-config-validator
run: vp dlx --package renovate renovate-config-validator
24 changes: 15 additions & 9 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,16 @@ jobs:
with:
persist-credentials: false

- name: Setup Node.js
uses: ./.github/actions/setup-node
- name: Setup Vite+
uses: voidzero-dev/setup-vp@1b32467adbe183473499fd9d5d372c3ed9641754 # v1.18.0
with:
cache: true

- name: Check TypeScript
run: pnpm tsc --noEmit
run: vp exec tsc --noEmit

- name: Run tests with coverage
run: pnpm test
run: vp run test

- name: Archive code coverage results
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
Expand Down Expand Up @@ -59,15 +61,17 @@ jobs:
with:
persist-credentials: false

- name: Setup Node.js
uses: ./.github/actions/setup-node
- name: Setup Vite+
uses: voidzero-dev/setup-vp@1b32467adbe183473499fd9d5d372c3ed9641754 # v1.18.0
with:
cache: true

- name: Run visual regression tests
# The job already runs in the pinned image, so the script runs vitest
# directly instead of starting another container.
env:
GITIFY_VISUAL_IN_CONTAINER: '1'
run: pnpm test:visual
run: vp run test:visual

# Vitest writes the actual and diff images here; the reference stays in
# __screenshots__. Download this to see what changed.
Expand Down Expand Up @@ -95,8 +99,10 @@ jobs:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
persist-credentials: false

- name: Setup Node.js
uses: ./.github/actions/setup-node
- name: Setup Vite+
uses: voidzero-dev/setup-vp@1b32467adbe183473499fd9d5d372c3ed9641754 # v1.18.0
with:
cache: true

- name: Download a single artifact
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
Expand Down