Repository navigation
Conversation
Add a required-check-ready workflow that calls notarytool history with the release Apple credentials. It fails when the Apple Developer Program License Agreement is missing or expired, with a message naming the Account Holder and both agreement locations. Release PRs created with GITHUB_TOKEN start their pull_request runs in action_required, so add an optional RELEASE_PLEASE_TOKEN (falling back to GITHUB_TOKEN) to let the check and the existing CI run automatically. Also add a publish preflight so manual dispatches fail fast, and document the new gate and token in CONTRIBUTING.
Keep the workflow approval gate instead of introducing a repo-wide write token. Document the Approve workflows to run step and fail the notarization check on the first 403; a maintainer can re-run it after Apple propagates the accepted agreement.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Context
The 8.2.0 release failed at macOS notarization with Apple's
HTTP 403: A required agreement is missing or has expired. Packaging then failed the matrix,Publish releasewas skipped, and nov8.2.0tag was created. release-please could not find the missing tag, scanned the whole history, and proposed a bogus 9.0.0 release.This PR adds a pre-merge gate so a stale Apple agreement blocks the release PR instead of a build hours later.
What changed
Apple notarization readiness, a check that callsnotarytool historywith the sameAPPLE_ID_*credentials the release uses. It authenticates without submitting an artifact, but returns the same 403 when an agreement is missing or expired.mainwithout blocking or slowing normal PRs.publish.ymlso manual dispatches fail in seconds instead of after build/sign/notarize.CONTRIBUTING.md.Tasks
GITHUB_TOKEN, so GitHub holds its workflow runs for approval before CI starts)Apple notarization readinessruns and passes (the workflow only exists onmain, so it cannot run on this PR)Apple notarization readinessto the required status checks formainmaincurrently hasenforce_admins: false, so admins can bypass required checks)publish.ymlfrom thev8.2.0tag ref (notmain), so the built source matches the release commitNotes
scripts/verifyAppleNotarization.shso the PR gate and the publish preflight use the same logic.Validation
actionlintshellcheck scripts/verifyAppleNotarization.shvp fmt --checkgit diff --check