Skip to content

chore: use pnpm and pnpm/setup - #30

Merged
afonsojramos merged 1 commit into
mainfrom
chore/mise
Nov 2, 2026
Merged

afonsojramos merged 1 commit into
mainfrom
chore/mise

Conversation

@setchy

@setchy setchy commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

Switches KDE from npm to pnpm:

  • Adds pnpm-lock.yaml and uses pnpm test / pnpm bundle.
  • CI uses pnpm/setup with .nvmrc, caching, and require-lockfile: true. pnpm/setup installs dependencies itself, so there is no separate install step.
  • Restores devEngines with both runtime and packageManager, so pnpm/setup and pnpm can resolve the pnpm version.
  • Keeps Python system-managed: scripts/test-live.py imports distro PyGObject.
  • Updates README/CONTRIBUTING for pnpm.

No mise: with Python system-managed, mise would only wrap Node/pnpm, which .nvmrc + devEngines.packageManager + pnpm/setup already handle.

Test plan

  • pnpm install --frozen-lockfile
  • pnpm test — 28 pass
  • pnpm bundle
  • node --check, bash -n, python3 -m py_compile
  • workflow YAML parses
  • CI is green

@setchy
setchy requested a review from afonsojramos as a code owner November 2, 2026 14:58
@setchy setchy mentioned this pull request Nov 2, 2026
6 of 7 tasks
@setchy setchy changed the title chore: adopt mise for Node and pnpm chore: use pnpm and pnpm/setup Nov 2, 2026
- replace npm with pnpm in CI and docs
- use pnpm/setup with .nvmrc, devEngines.packageManager, and the pnpm lockfile
- let pnpm/setup install dependencies with the frozen lockfile
- keep Python system-managed for the PyGObject live test
@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@afonsojramos
afonsojramos merged commit bd503b9 into main Nov 2, 2026
2 checks passed
@afonsojramos
afonsojramos deleted the chore/mise branch November 2, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants