add crates-sync image - #2172
Conversation
Add run_job.py for wait/bootstrap against mono, freighter hostPath paths, and keep-crate-cache so shared caches are not deleted. Ship Dockerfile plus crates-sync deploy workflow for onprem Jobs.
Prevents parent paths like /third-party/rust from shadowing leaf import repos in tree browsing via find_git_repo_like_path prefix matching. Co-authored-by: Cursor <cursoragent@cursor.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb27a7710f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if let Some(descendant) = git_repo::Entity::find() | ||
| .filter(git_repo::Column::RepoPath.like(format!("{path}/%"))) | ||
| .one(self.get_connection()) |
There was a problem hiding this comment.
When repo_path contains _ or %—both relevant because crate/import repository names may contain underscores—passing "{path}/%" directly to SQL LIKE treats those characters as wildcards. An existing sibling such as a path differing at an underscore position can therefore be returned as a supposed descendant, causing otherwise valid pushes and create_repo_and_save_ref calls to fail with a nested-repository conflict. Escape wildcard characters or construct the prefix predicate without LIKE pattern semantics.
Useful? React with 👍 / 👎.
1 participant
No description provided.