Repository navigation
Pin development images to Go 1.26.9 and golangci-lint v2.15.0 - #21639
Merged
Merged
Conversation
Install the linter in a dedicated directory with PATH precedence. Allow manual workflow dispatches to disable Leeway caching for both development-image and component builds.
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Contributor
|
|
Co-authored-by: Codex <noreply@openai.com>
kbrennan-oai
approved these changes
Oct 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pins Go to 1.26.9 and installs
github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.15.0indev/image/Dockerfileand.devcontainer/Dockerfile. The pinned linter lives in/opt/golangci-lint/bin, which takes precedence on PATH.This is the first stage of the rollout documented in dev/image/README.md. Once these changes land, the main build publishes a new
eu.gcr.io/gitpod-core-dev/dev/dev-environment:main-gha.<run>image. A separate follow-up PR will update workflow and.gitpod.ymlconsumers to that published image.This PR changes only the two Dockerfiles. Existing consumer image references and workflows remain unchanged.
Related to #21636, which also upgrades Go to 1.26.9 as part of broader Go vulnerability remediation.
Validation
--cache none, lint and tests enabled, Go 1.26.9, and golangci-lint v2.15.0. Toolchain checks confirmed the pinned linter wins on PATH.ER_TABLE_DEF_CHANGEDerror. Both passed with the candidate image.git diff --checkpassed after reducing the scope to the two Dockerfiles.The candidate validation workflow is red because its later SBOM export could not find artifacts after the uncached build (
components:needs-vuln-scan is not built). This was reproduced locally; the full Leeway build itself passed. No golangci-lint v2 compatibility failure was found.