Added support for original field and type naming for C++ language. - #2639
Merged
Conversation
The "original" style returned names verbatim, skipping combineWords entirely, so JSON keys that aren't valid identifiers produced uncompilable C++ (e.g. "some-header" emitted as a member name, or a leading-digit key like "9lives"). Route "original" through combineWords as a single unsplit word instead: casing and legal characters (including underscores) are preserved exactly, while illegal characters are stripped, invalid start characters get the usual "the" prefix, and empty names are handled. This matches the semantics of the existing "--acronym-style original" option. Reserved words like "class" were already handled by the renderer's forbidden-names machinery and still are. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for keeping original names for the C++ generator.
Motivation and Context
Previous Behaviour / Output
The CLI had the option for pascal-case, underscore-case, camel-case and others.
New Behaviour / Output
Now it supports original-case for fields and types.