Correctly combine zpk systems#34
Open
MitchellThompkins wants to merge 1 commit into
Open
Conversation
MitchellThompkins
force-pushed
the
mitchellthompkins/combine-zpk-systems
branch
from
9f3567b to
e5a5992
Compare
MitchellThompkins
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#31 (comment) pointed out that
This is of course wrong and I've tried to address it here. While addressing I also realized a number of functions were also returning
tfdata types because they delegate totf. That's of course also wrong because when you work withzpkyou should expect to stay in that data type (even if the backing implementation degrades to another system representation).Changes
zpkdata types they all actually returnzpk.__times__(.*),__sys_group__(+) now return the correct types and data shape (I think)